compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 10690074: Migrates some resolver errors to parser stage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10690074: Migrates some resolver errors to parser stage (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: # Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index b2224655781fa0c00433b8d76c9636f6ad1b0111..107ab72de55a50fb2b41f6b97f104ed48b2d3fd5 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -1699,7 +1699,8 @@ public class TypeAnalyzer implements DartCompilationPhase {

MethodElement methodElement = node.getElement();

Modifiers modifiers = methodElement.getModifiers();

DartTypeNode returnTypeNode = node.getFunction().getReturnTypeNode();

- if (modifiers.isFactory()) {

+ if (modifiers.isFactory()

+ && ElementKind.of(methodElement).equals(ElementKind.CONSTRUCTOR)) {

analyzeFactory(node.getName(), (ConstructorElement) methodElement);

} else if (modifiers.isSetter()) {

if (returnTypeNode != null && returnTypeNode.getType() != voidType) {