Issue 10690002: Fix some issues when debugging against package: libraries (Dartium and command-line).

Issue 10690002: Fix some issues when debugging against package: libraries (Dartium and command-line). (Closed)

Created:
8 years, 6 months ago by devoncarew

Modified:
8 years, 6 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix some issues when debugging against package: libraries (Dartium and command-line). Some general cleanup of logging messages on connection close. Committed: https://code.google.com/p/dart/source/detail?r=9147

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -24 lines)			Patch
M	compiler/java/com/google/dart/compiler/SystemLibraryManager.java	View	1 2	4 chunks	+22 lines, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerRemoteScriptSourceContainer.java	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/BrowserManager.java	View	1 2	2 chunks	+10 lines, -6 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/ResourceServer.java	View	1 2	2 chunks	+8 lines, -8 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/ResourceServerHandler.java	View	1 2	3 chunks	+12 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/webkit/WebkitDebugger.java	View	1 2	1 chunk	+7 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java	View	1 2	3 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danrubel

lgtm LGTM with 2 suggestions. http://codereview.chromium.org/10690002/diff/1001/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java File editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java (right): http://codereview.chromium.org/10690002/diff/1001/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java#newcode110 editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java:110: if ("package".equals(uri.getScheme())) { Better ...

8 years, 6 months ago (2012-06-27 04:19:46 UTC) #2

devoncarew

8 years, 6 months ago (2012-06-27 04:44:08 UTC) #3

http://codereview.chromium.org/10690002/diff/1001/editor/tools/plugins/com.go...
File
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java
(right):

http://codereview.chromium.org/10690002/diff/1001/editor/tools/plugins/com.go...
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java:110:
if ("package".equals(uri.getScheme())) {
Done - I added a new method to SystemLibraryManager to get this working. LMK
what you think -

http://codereview.chromium.org/10690002/diff/1001/editor/tools/plugins/com.go...
File
editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java
(right):

http://codereview.chromium.org/10690002/diff/1001/editor/tools/plugins/com.go...
editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java:185:
if (url.startsWith("package:")) {
On 2012/06/27 04:19:46, danrubel wrote:
> Same comment as before.

Done.

Expand Messages | Collapse Messages