editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/webkit/WebkitDebugger.java - Issue 10690002: Fix some issues when debugging against package: libraries (Dartium and command-line).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/webkit/WebkitDebugger.java

Issue 10690002: Fix some issues when debugging against package: libraries (Dartium and command-line). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/ResourceServerHandler.java ('k') | editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/webkit/WebkitDebugger.java

===================================================================

--- editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/webkit/WebkitDebugger.java (revision 9145)

+++ editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/webkit/WebkitDebugger.java (working copy)

@@ -547,10 +547,14 @@

} else if (method.equals(DEBUGGER_SCRIPT_PARSED)) {

WebkitScript script = WebkitScript.createFrom(params);

- scriptMap.put(script.getScriptId(), script);

+ // We get a blizzard of empty script parsed events from Dartium due to the way they integrated

+ // the Dart VM into the Webkit debugger.

+ if (script.getUrl().length() > 0) {

+ scriptMap.put(script.getScriptId(), script);

- for (DebuggerListener listener : listeners) {

- listener.debuggerScriptParsed(script);

+ for (DebuggerListener listener : listeners) {

+ listener.debuggerScriptParsed(script);

+ }

}

} else if (method.equals(DEBUGGER_BREAKPOINT_RESOLVED)) {

WebkitBreakpoint breakpoint = WebkitBreakpoint.createFrom(params);