Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java

Issue 10690002: Fix some issues when debugging against package: libraries (Dartium and command-line). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java (revision 9145)
+++ editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java (working copy)
@@ -14,6 +14,9 @@
package com.google.dart.tools.debug.ui.internal.view;
+import com.google.dart.compiler.SystemLibraryManager;
+import com.google.dart.tools.core.DartCore;
+import com.google.dart.tools.core.internal.model.SystemLibraryManagerProvider;
import com.google.dart.tools.core.internal.util.ResourceUtil;
import com.google.dart.tools.ui.DartUI;
@@ -142,7 +145,6 @@
// don't create a hyperlink
}
-
}
private IFile getIFileForAbsolutePath(String pathStr) {
@@ -178,7 +180,14 @@
// /Users/foo/dart/serverapp/serverapp.dart
// file:///Users/foo/dart/webapp2/webapp2.dart
// http://0.0.0.0:3030/webapp/webapp.dart
+ // package:ihavea/ihavea.dart
+ // resolve package: urls to file: urls
+ if (SystemLibraryManager.isPackageSpec(url)
+ && DartCore.getPlugin().getPackageRootPref() != null) {
+ url = SystemLibraryManagerProvider.getSystemLibraryManager().resolvePackageUri(url).toString();
+ }
+
// Handle both fully absolute path names and http: urls.
if (url.startsWith("/")) {
IFile file = getIFileForAbsolutePath(url);
« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/webkit/WebkitDebugger.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698