Issue 10599003: Don't call FixJavaHome() during dart-editor* builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10599003: Don't call FixJavaHome() during dart-editor* builds (Closed)

Created:
8 years, 6 months ago by danrubel

Modified:
8 years, 6 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't call FixJavaHome() during dart-editor* builds Committed: https://code.google.com/p/dart/source/detail?r=8949

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	client/tools/buildbot_annotated_steps.py	View		1 chunk	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ricow1

8 years, 6 months ago (2012-06-21 05:56:02 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10599003/diff/1/client/tools/buildbot_...
File client/tools/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/10599003/diff/1/client/tools/buildbot_...
client/tools/buildbot_annotated_steps.py:155: # TODO (danrubel) Fix dart-editor
builds so that we can call FixJavaHome() before the build
long line

Expand Messages | Collapse Messages