client/tools/buildbot_annotated_steps.py - Issue 10599003: Don't call FixJavaHome() during dart-editor* builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/tools/buildbot_annotated_steps.py

Issue 10599003: Don't call FixJavaHome() during dart-editor* builds (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/tools/buildbot_annotated_steps.py

===================================================================

--- client/tools/buildbot_annotated_steps.py (revision 8911)

+++ client/tools/buildbot_annotated_steps.py (working copy)

@@ -151,12 +151,13 @@

#TODO(sigmund): remove this indirection once we update our bots

(name, version) = GetBuildInfo()

- # The buildbot will set a BUILDBOT_JAVA_HOME relative to the dart

- # root directory, set JAVA_HOME based on that.

- FixJavaHome()

if name.startswith('dart-editor'):

+ # TODO (danrubel) Fix dart-editor builds so that we can call FixJavaHome() before the build

ricow1 2012/06/21 05:56:02 long line

status = ProcessTools('release', name, version)

else:

+ # The buildbot will set a BUILDBOT_JAVA_HOME relative to the dart

+ # root directory, set JAVA_HOME based on that.

+ FixJavaHome()

status = ProcessCompiler(name)

if status:

« no previous file with comments | « no previous file | no next file » | no next file with comments »