Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: client/tools/buildbot_annotated_steps.py

Issue 10599003: Don't call FixJavaHome() during dart-editor* builds (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 #!/usr/bin/python 5 #!/usr/bin/python
6 6
7 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 7 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
8 # Use of this source code is governed by a BSD-style license that can be 8 # Use of this source code is governed by a BSD-style license that can be
9 # found in the LICENSE file. 9 # found in the LICENSE file.
10 10
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 if len(sys.argv) == 0: 144 if len(sys.argv) == 0:
145 print 'Script pathname not known, giving up.' 145 print 'Script pathname not known, giving up.'
146 return 1 146 return 1
147 147
148 scriptdir = os.path.dirname(sys.argv[0]) 148 scriptdir = os.path.dirname(sys.argv[0])
149 # Get at the top-level directory. This script is in client/tools 149 # Get at the top-level directory. This script is in client/tools
150 os.chdir(os.path.abspath(os.path.join(scriptdir, os.pardir, os.pardir))) 150 os.chdir(os.path.abspath(os.path.join(scriptdir, os.pardir, os.pardir)))
151 151
152 #TODO(sigmund): remove this indirection once we update our bots 152 #TODO(sigmund): remove this indirection once we update our bots
153 (name, version) = GetBuildInfo() 153 (name, version) = GetBuildInfo()
154 # The buildbot will set a BUILDBOT_JAVA_HOME relative to the dart
155 # root directory, set JAVA_HOME based on that.
156 FixJavaHome()
157 if name.startswith('dart-editor'): 154 if name.startswith('dart-editor'):
155 # TODO (danrubel) Fix dart-editor builds so that we can call FixJavaHome() b efore the build
ricow1 2012/06/21 05:56:02 long line
158 status = ProcessTools('release', name, version) 156 status = ProcessTools('release', name, version)
159 else: 157 else:
158 # The buildbot will set a BUILDBOT_JAVA_HOME relative to the dart
159 # root directory, set JAVA_HOME based on that.
160 FixJavaHome()
160 status = ProcessCompiler(name) 161 status = ProcessCompiler(name)
161 162
162 if status: 163 if status:
163 print '@@@STEP_FAILURE@@@' 164 print '@@@STEP_FAILURE@@@'
164 165
165 return status 166 return status
166 167
167 168
168 if __name__ == '__main__': 169 if __name__ == '__main__':
169 sys.exit(main()) 170 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698