Proper support for IDL arrays in generators.

Proper support for IDL arrays in generators.

R=podivilov@chromium.org,sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=8969

[podivilov, 2012-06-20 15:08:39]

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:762: 'DOMString[]': IDLTypeInfo('DOMStringList',
dart_type='List<String>', custom_to_native=True),
Is there any difference between DOMString[] and DOMStringList? Shouldn't we
treat them differently in Dart?

[Anton Muhin, 2012-06-20 15:13:54]

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:762: 'DOMString[]': IDLTypeInfo('DOMStringList',
dart_type='List<String>', custom_to_native=True),
For now I just followed v8 bindings which apparently treat them as same things.

On 2012/06/20 15:08:39, podivilov wrote:
> Is there any difference between DOMString[] and DOMStringList? Shouldn't we
> treat them differently in Dart?

[podivilov, 2012-06-20 15:54:46]

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:762: 'DOMString[]': IDLTypeInfo('DOMStringList',
dart_type='List<String>', custom_to_native=True),
On 2012/06/20 15:13:54, antonmuhin wrote:
> For now I just followed v8 bindings which apparently treat them as same
things.
> 
> On 2012/06/20 15:08:39, podivilov wrote:
> > Is there any difference between DOMString[] and DOMStringList? Shouldn't we
> > treat them differently in Dart?
> 

If they are the same things, we should just fix the IDLs upstream.
But I believe they are treated differently by CodeGeneratorV8.pm.

[sra1, 2012-06-20 16:33:26]

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:762: 'DOMString[]': IDLTypeInfo('DOMStringList',
dart_type='List<String>', custom_to_native=True),
On 2012/06/20 15:54:46, podivilov wrote:
> On 2012/06/20 15:13:54, antonmuhin wrote:
> > For now I just followed v8 bindings which apparently treat them as same
> things.
> > 
> > On 2012/06/20 15:08:39, podivilov wrote:
> > > Is there any difference between DOMString[] and DOMStringList? Shouldn't
we
> > > treat them differently in Dart?
> > 
> 
> If they are the same things, we should just fix the IDLs upstream.
> But I believe they are treated differently by CodeGeneratorV8.pm.

I think that they are not the same.
On Chrome the methods returning DOMStringList return an object x with the
x.constructor.name == 'DOMStringList'.
We need to know which are declared as returning or taking DOMStringList for the
JS bindings, since we will have to inject different tests and possibly a
different conversion there.

[Anton Muhin, 2012-06-20 18:45:47]

ptal

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10584031/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:762: 'DOMString[]': IDLTypeInfo('DOMStringList',
dart_type='List<String>', custom_to_native=True),
Sorry, I indeed missed that they create a fresh array when convert returned
result.  Fixed.

[podivilov, 2012-06-21 08:33:57]

lgtm

https://chromiumcodereview.appspot.com/10584031/diff/2002/lib/dom/scripts/gen...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10584031/diff/2002/lib/dom/scripts/gen...
lib/dom/scripts/generator.py:789: 'DOMString[]': DOMStringArrayTypeInfo(),
Up to you, but I really prefer a special case in GetIDLTypeInfo.