Remove support for String operator + from dart2js.

Remove support for String operator + from dart2js.

Committed: https://code.google.com/p/dart/source/detail?r=8778

[ahe, 2012-06-18 08:34:54]

Updated to use JavaScript's Array.join.

[floitsch, 2012-06-18 09:04:17]

LGTM.

[Lasse Reichstein Nielsen, 2012-06-18 09:25:32]

LGTM.

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/lib/mockimpl.dart (right):

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/compiler/i...
dart/lib/compiler/implementation/lib/mockimpl.dart:161: checkNull(string);
Do we really want to throw a NPE instead of an IAE in this case? Null us just an
invalid argument too.

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/isolate/fr...
File dart/lib/isolate/frog/messages.dart (right):

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/isolate/fr...
dart/lib/isolate/frog/messages.dart:153: throw
I liked the original indentation better. Just remove the '+' but keep the
indentation.
It tricks an old JS programmer to see a newline between "throw" and it's operand
- that's not allowed in JS.

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/isolate/fr...
dart/lib/isolate/frog/messages.dart:207: " ports are resolved at this point.";
Ditto.

[ahe, 2012-06-18 10:39:16]

Hi Lasse and Florian,

Thank you for taking a look?

Cheers,
Peter

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/lib/mockimpl.dart (right):

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/compiler/i...
dart/lib/compiler/implementation/lib/mockimpl.dart:161: checkNull(string);
On 2012/06/18 09:25:32, Lasse Reichstein Nielsen wrote:
> Do we really want to throw a NPE instead of an IAE in this case? Null us just
an
> invalid argument too.

This is what the other implementation does. I cannot pass co19 tests unless I
check this.

If you think this is problematic, document the API. As long as the API is
virtually unspecified, the co19 test writers had to guess the specification
based on early implementations.

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/isolate/fr...
File dart/lib/isolate/frog/messages.dart (right):

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/isolate/fr...
dart/lib/isolate/frog/messages.dart:153: throw
On 2012/06/18 09:25:32, Lasse Reichstein Nielsen wrote:
> I liked the original indentation better. Just remove the '+' but keep the
> indentation.
> It tricks an old JS programmer to see a newline between "throw" and it's
operand
> - that's not allowed in JS.

I don't follow the logic of your argument.

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/isolate/fr...
dart/lib/isolate/frog/messages.dart:207: " ports are resolved at this point.";
On 2012/06/18 09:25:32, Lasse Reichstein Nielsen wrote:
> Ditto.

Ditto.

[kasperl, 2012-06-18 11:35:55]

LGTM.

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/compiler/i...
dart/lib/compiler/implementation/ssa/nodes.dart:1400: bool get builtin() =>
left.isNumber() && right.isNumber();
This isn't needed anymore.

[ahe, 2012-06-18 11:47:19]

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10553007/diff/8001/dart/lib/compiler/i...
dart/lib/compiler/implementation/ssa/nodes.dart:1400: bool get builtin() =>
left.isNumber() && right.isNumber();
On 2012/06/18 11:35:55, kasperl wrote:
> This isn't needed anymore.

Because this is what the superclass does already. I'll fix this in a follow-up
CL.

[kasperl, 2012-06-18 11:49:16]

On 2012/06/18 11:47:19, ahe wrote:
> Because this is what the superclass does already. 

Thank you for completing my sentence :-)