dart/lib/compiler/implementation/compile_time_constants.dart - Issue 10553007: Remove support for String operator + from dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/lib/compiler/implementation/compile_time_constants.dart

Issue 10553007: Remove support for String operator + from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Update co19 status Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/lib/compiler/implementation/compile_time_constants.dart

diff --git a/dart/lib/compiler/implementation/compile_time_constants.dart b/dart/lib/compiler/implementation/compile_time_constants.dart

index 41f9019a34b5321dbff1b900de5f52f22420bf71..ae7fe1d2eaa8afa7caaa26c67114e44e162bb038 100644

--- a/dart/lib/compiler/implementation/compile_time_constants.dart

+++ b/dart/lib/compiler/implementation/compile_time_constants.dart

@@ -869,11 +869,6 @@ class CompileTimeConstantEvaluator extends AbstractVisitor {

Constant folded = null;

switch (op.source.stringValue) {

case "+":

- if (left.isString() && !right.isString()) {

- // At the moment only compile-time concatenation of two strings is

- // allowed.

- error(send);

- }

folded = const AddOperation().fold(left, right);

break;

case "-":