Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: dart/lib/compiler/implementation/lib/js_helper.dart

Issue 10553007: Remove support for String operator + from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update co19 status Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/lib/js_helper.dart
diff --git a/dart/lib/compiler/implementation/lib/js_helper.dart b/dart/lib/compiler/implementation/lib/js_helper.dart
index a5cb94f47ff5942f94820fd7f4ae4fd50ab75731..508d52dc88fedc1507dfbc09a61e78a888fbe055 100644
--- a/dart/lib/compiler/implementation/lib/js_helper.dart
+++ b/dart/lib/compiler/implementation/lib/js_helper.dart
@@ -118,14 +118,6 @@ bool isJsArray(var value) {
add$slow(var a, var b) {
if (checkNumbers(a, b)) {
return JS('num', @'# + #', a, b);
- } else if (a is String) {
- // TODO(lrn): Remove when we disable String.operator+
- b = b.toString();
- if (b is String) {
- return JS('String', @'# + #', a, b);
- }
- checkNull(b);
- throw new IllegalArgumentException(b);
}
return UNINTERCEPTED(a + b);
}

Powered by Google App Engine
This is Rietveld 408576698