Fixes for checked mode and change buildbot script to run dart2js tests in checked mode also.

Fixes for checked mode and change buildbot script to run dart2js tests in checked mode also.
Committed: https://code.google.com/p/dart/source/detail?r=8382

[ngeoffray, 2012-06-07 08:27:22]

New CL updated with the removal of HCheckStatement. PTAL

[kasperl, 2012-06-07 08:29:14]

It would be nice to see if you could get rid of the HCheckStatement. Somehow it
feels a bit weird to represent whether or not something can be code generated as
a JavaScript expression in the inheritance hierarchy for the SSA instructions.

https://chromiumcodereview.appspot.com/10543027/diff/2002/lib/compiler/implem...
File lib/compiler/implementation/ssa/variable_allocator.dart (right):

https://chromiumcodereview.appspot.com/10543027/diff/2002/lib/compiler/implem...
lib/compiler/implementation/ssa/variable_allocator.dart:452: if (instruction is
HParameterValue) {
There's something a bit fishy about the control flow here. If it is an HCheck
you don't have to check if it is a HParameterValue. Maybe you can just move the
HParameterValue check out of the name == null if?

https://chromiumcodereview.appspot.com/10543027/diff/2002/lib/compiler/implem...
lib/compiler/implementation/ssa/variable_allocator.dart:472:
usedNames.add(name);
You could also create a helper function for this last part so you could do
something ala:

   if (name !== null) return addAllocatedName(instruction, name);

thereby returning earlier and simplifying the control flow a bit.

[kasperl, 2012-06-07 08:30:50]

LGTM.

https://chromiumcodereview.appspot.com/10543027/diff/5010/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10543027/diff/5010/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:545: // emit an assignment.
... because?

https://chromiumcodereview.appspot.com/10543027/diff/5010/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:562: if
(!handleSimpleUpdateDefinition(instruction, name)
Add a comment that explains what this does?

https://chromiumcodereview.appspot.com/10543027/diff/5010/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:582: HInstruction checkedInput =
argument.checkedInput;
check.checkedInput?

[ngeoffray, 2012-06-07 09:02:41]

Thanks Kasper

https://chromiumcodereview.appspot.com/10543027/diff/2002/lib/compiler/implem...
File lib/compiler/implementation/ssa/variable_allocator.dart (right):

https://chromiumcodereview.appspot.com/10543027/diff/2002/lib/compiler/implem...
lib/compiler/implementation/ssa/variable_allocator.dart:452: if (instruction is
HParameterValue) {
On 2012/06/07 08:29:14, kasperl wrote:
> There's something a bit fishy about the control flow here. If it is an HCheck
> you don't have to check if it is a HParameterValue. Maybe you can just move
the
> HParameterValue check out of the name == null if?

Done.

https://chromiumcodereview.appspot.com/10543027/diff/2002/lib/compiler/implem...
lib/compiler/implementation/ssa/variable_allocator.dart:472:
usedNames.add(name);
On 2012/06/07 08:29:14, kasperl wrote:
> You could also create a helper function for this last part so you could do
> something ala:
> 
>    if (name !== null) return addAllocatedName(instruction, name);
> 
> thereby returning earlier and simplifying the control flow a bit.

Done.

https://chromiumcodereview.appspot.com/10543027/diff/5010/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10543027/diff/5010/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:545: // emit an assignment.
On 2012/06/07 08:30:50, kasperl wrote:
> ... because?

intTypeCheck just returns its argument. Done.

https://chromiumcodereview.appspot.com/10543027/diff/5010/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:562: if
(!handleSimpleUpdateDefinition(instruction, name)
On 2012/06/07 08:30:50, kasperl wrote:
> Add a comment that explains what this does?

The comment is on the handleTypeConversion method.

https://chromiumcodereview.appspot.com/10543027/diff/5010/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:582: HInstruction checkedInput =
argument.checkedInput;
On 2012/06/07 08:30:50, kasperl wrote:
> check.checkedInput?

Done.