Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: utils/compiler/buildbot.py

Issue 10543027: Fixes for checked mode and change buildbot script to run dart2js tests in checked mode also. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/standalone/standalone.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Dart frog buildbot steps 7 """Dart frog buildbot steps
8 8
9 Runs tests for the frog or dart2js compiler. 9 Runs tests for the frog or dart2js compiler.
10 """ 10 """
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 print '@@@STEP_FAILURE@@@' 270 print '@@@STEP_FAILURE@@@'
271 return status 271 return status
272 272
273 test_flags = [] 273 test_flags = []
274 if shard_index: 274 if shard_index:
275 test_flags = ['--shards=%s' % total_shards, '--shard=%s' % shard_index] 275 test_flags = ['--shards=%s' % total_shards, '--shard=%s' % shard_index]
276 276
277 # First we run all the regular tests. 277 # First we run all the regular tests.
278 status = TestCompiler(compiler, runtime, mode, system, option, test_flags) 278 status = TestCompiler(compiler, runtime, mode, system, option, test_flags)
279 279
280 # BUG(3281): We do not run checked mode tests on dart2js. 280 # We only run checked mode tests when the host is not in checked mode.
281 if status == 0 and compiler != 'dart2js': 281 if status == 0 and option != 'checked' and runtime == 'd8':
282 status = TestCompiler(compiler, runtime, mode, system, option, 282 status = TestCompiler(compiler, runtime, mode, system, option,
283 test_flags + ['--checked']) 283 test_flags + ['--checked'])
284 284
285 if runtime != 'd8': CleanUpTemporaryFiles(system, runtime) 285 if runtime != 'd8': CleanUpTemporaryFiles(system, runtime)
286 if status != 0: print '@@@STEP_FAILURE@@@' 286 if status != 0: print '@@@STEP_FAILURE@@@'
287 return status 287 return status
288 288
289 if __name__ == '__main__': 289 if __name__ == '__main__':
290 sys.exit(main()) 290 sys.exit(main())
OLDNEW
« no previous file with comments | « tests/standalone/standalone.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698