Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10543027: Fixes for checked mode and change buildbot script to run dart2js tests in checked mode also. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | lib/compiler/implementation/ssa/tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/optimize.dart
===================================================================
--- lib/compiler/implementation/ssa/optimize.dart (revision 8378)
+++ lib/compiler/implementation/ssa/optimize.dart (working copy)
@@ -542,6 +542,7 @@
}
// TODO(karlklose): remove the hasTypeArguments check.
} else if (expressionType.isUseful()
+ && !expressionType.canBeNull()
&& !compiler.codegenWorld.rti.hasTypeArguments(type)) {
Type receiverType = expressionType.computeType(compiler);
if (receiverType !== null) {
@@ -569,6 +570,7 @@
HInstruction visitInvokeDynamicGetter(HInvokeDynamicGetter node) {
HInstruction receiver = node.inputs[0];
if (!receiver.propagatedType.isUseful()) return node;
+ if (receiver.propagatedType.canBeNull()) return node;
Type type = receiver.propagatedType.computeType(compiler);
if (type === null) return node;
Element field = compiler.world.locateSingleField(type, node.name);
@@ -584,6 +586,7 @@
HInstruction visitInvokeDynamicSetter(HInvokeDynamicSetter node) {
HInstruction receiver = node.inputs[0];
if (!receiver.propagatedType.isUseful()) return node;
+ if (receiver.propagatedType.canBeNull()) return node;
Type type = receiver.propagatedType.computeType(compiler);
if (type === null) return node;
Element field = compiler.world.locateSingleField(type, node.name);
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | lib/compiler/implementation/ssa/tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698