Issue 10541069: Add more intrinsics, enable new compiler's optimized mode for ia32.

Issue 10541069: Add more intrinsics, enable new compiler's optimized mode for ia32. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add more intrinsics, enable new compiler's optimized mode for ia32. Committed: https://code.google.com/p/dart/source/detail?r=8442

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -6 lines)			Patch
	M	runtime/vm/compiler.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
	M	runtime/vm/intrinsifier_x64.cc	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10541069/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10541069/diff/1/runtime/vm/compiler.cc#newcode199 runtime/vm/compiler.cc:199: // produced by the FlowGraphOptimizer are implemented on ...

8 years, 6 months ago (2012-06-08 11:32:53 UTC) #2

srdjan

8 years, 6 months ago (2012-06-08 14:55:24 UTC) #3

https://chromiumcodereview.appspot.com/10541069/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://chromiumcodereview.appspot.com/10541069/diff/1/runtime/vm/compiler.cc...
runtime/vm/compiler.cc:199: // produced by the FlowGraphOptimizer are
implemented on ia32.
On 2012/06/08 11:32:53, Vyacheslav Egorov (Google) wrote:
> remove this comment?

Done.

https://chromiumcodereview.appspot.com/10541069/diff/1/runtime/vm/intrinsifie...
File runtime/vm/intrinsifier_x64.cc (right):

https://chromiumcodereview.appspot.com/10541069/diff/1/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_x64.cc:133: // Note that RCX is Smi, i.e, times 2.
On 2012/06/08 11:32:53, Vyacheslav Egorov (Google) wrote:
> times 4

Done.

https://chromiumcodereview.appspot.com/10541069/diff/1/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_x64.cc:159: // Note that EBX is Smi, i.e, times 2.
On 2012/06/08 11:32:53, Vyacheslav Egorov (Google) wrote:
> times 4

Done.

Expand Messages | Collapse Messages