Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 10541069: Add more intrinsics, enable new compiler's optimized mode for ia32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_x64.cc
===================================================================
--- runtime/vm/intrinsifier_x64.cc (revision 8440)
+++ runtime/vm/intrinsifier_x64.cc (working copy)
@@ -116,17 +116,69 @@
}
+// Access growable object array at specified index.
+// On stack: growable array (+2), index (+1), return-address (+0).
bool Intrinsifier::GrowableArray_getIndexed(Assembler* assembler) {
+ Label fall_through;
+ __ movq(RCX, Address(RSP, + 1 * kWordSize)); // Index.
+ __ movq(RAX, Address(RSP, + 2 * kWordSize)); // GrowableArray.
+ __ testq(RCX, Immediate(kSmiTagMask));
+ __ j(NOT_ZERO, &fall_through, Assembler::kNearJump); // Non-smi index.
+ // Range check using _length field.
+ __ cmpq(RCX, FieldAddress(RAX, GrowableObjectArray::length_offset()));
+ // Runtime throws exception.
+ __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
+ __ movq(RAX, FieldAddress(RAX, GrowableObjectArray::data_offset())); // data.
+
+ // Note that RCX is Smi, i.e, times 4.
+ ASSERT(kSmiTagShift == 1);
+ __ movq(RAX, FieldAddress(RAX, RCX, TIMES_4, sizeof(RawArray)));
+ __ ret();
+ __ Bind(&fall_through);
return false;
}
+// Set value into growable object array at specified index.
+// On stack: growable array (+3), index (+2), value (+1), return-address (+0).
bool Intrinsifier::GrowableArray_setIndexed(Assembler* assembler) {
+ if (FLAG_enable_type_checks) {
+ return false;
+ }
+ __ movq(RDX, Address(RSP, + 1 * kWordSize)); // Value.
+ __ movq(RCX, Address(RSP, + 2 * kWordSize)); // Index.
+ __ movq(RAX, Address(RSP, + 3 * kWordSize)); // GrowableArray.
+ Label fall_through;
+ __ testq(RCX, Immediate(kSmiTagMask));
+ __ j(NOT_ZERO, &fall_through, Assembler::kNearJump); // Non-smi index.
+ // Range check using _length field.
+ __ cmpq(RCX, FieldAddress(RAX, GrowableObjectArray::length_offset()));
+ // Runtime throws exception.
+ __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
+ __ movq(RAX, FieldAddress(RAX, GrowableObjectArray::data_offset())); // data.
+ // Note that RCX is Smi, i.e, times 4.
+ ASSERT(kSmiTagShift == 1);
+ __ StoreIntoObject(RAX,
+ FieldAddress(RAX, RCX, TIMES_4, sizeof(RawArray)),
+ RDX);
+ __ ret();
+ __ Bind(&fall_through);
return false;
}
+// Set length of growable object array.
+// On stack: growable array (+2), length (+1), return-address (+0).
bool Intrinsifier::GrowableArray_setLength(Assembler* assembler) {
+ Label fall_through;
+ __ movq(RAX, Address(RSP, + 2 * kWordSize)); // Growable array.
+ __ movq(RCX, Address(RSP, + 1 * kWordSize)); // Length.
+ __ movq(RDX, FieldAddress(RAX, GrowableObjectArray::data_offset()));
+ __ cmpq(RCX, FieldAddress(RDX, Array::length_offset()));
+ __ j(ABOVE, &fall_through, Assembler::kNearJump);
+ __ movq(FieldAddress(RAX, GrowableObjectArray::length_offset()), RCX);
+ __ ret();
+ __ Bind(&fall_through);
return false;
}
« no previous file with comments | « runtime/vm/compiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698