Add more intrinsics, enable new compiler's optimized mode for ia32.

runtime/vm/intrinsifier_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 98 matching lines @@
 
 bool Intrinsifier::GrowableArray_getCapacity(Assembler* assembler) {
   __ movq(RAX, Address(RSP, + 1 * kWordSize));
   __ movq(RAX, FieldAddress(RAX, GrowableObjectArray::data_offset()));
   __ movq(RAX, FieldAddress(RAX, Array::length_offset()));
   __ ret();
   return true;
 }
 
 
+// Access growable object array at specified index.
+// On stack: growable array (+2), index (+1), return-address (+0).
 bool Intrinsifier::GrowableArray_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  __ movq(RCX, Address(RSP, + 1 * kWordSize));  // Index.
+  __ movq(RAX, Address(RSP, + 2 * kWordSize));  // GrowableArray.
+  __ testq(RCX, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi index.
+  // Range check using _length field.
+  __ cmpq(RCX, FieldAddress(RAX, GrowableObjectArray::length_offset()));
+  // Runtime throws exception.
+  __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
+  __ movq(RAX, FieldAddress(RAX, GrowableObjectArray::data_offset()));  // data.
+
+  // Note that RCX is Smi, i.e, times 2.

[Vyacheslav Egorov (Google), 2012/06/08 11:32:53]

times 4

[srdjan, 2012/06/08 14:55:24]

Done.

+  ASSERT(kSmiTagShift == 1);
+  __ movq(RAX, FieldAddress(RAX, RCX, TIMES_4, sizeof(RawArray)));
+  __ ret();
+  __ Bind(&fall_through);
   return false;
 }
 
 
+// Set value into growable object array at specified index.
+// On stack: growable array (+3), index (+2), value (+1), return-address (+0).
 bool Intrinsifier::GrowableArray_setIndexed(Assembler* assembler) {
+  if (FLAG_enable_type_checks) {
+    return false;
+  }
+  __ movq(RDX, Address(RSP, + 1 * kWordSize));  // Value.
+  __ movq(RCX, Address(RSP, + 2 * kWordSize));  // Index.
+  __ movq(RAX, Address(RSP, + 3 * kWordSize));  // GrowableArray.
+  Label fall_through;
+  __ testq(RCX, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi index.
+  // Range check using _length field.
+  __ cmpq(RCX, FieldAddress(RAX, GrowableObjectArray::length_offset()));
+  // Runtime throws exception.
+  __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
+  __ movq(RAX, FieldAddress(RAX, GrowableObjectArray::data_offset()));  // data.
+  // Note that EBX is Smi, i.e, times 2.

[Vyacheslav Egorov (Google), 2012/06/08 11:32:53]

times 4

[srdjan, 2012/06/08 14:55:24]

Done.

+  ASSERT(kSmiTagShift == 1);
+  __ StoreIntoObject(RAX,
+                     FieldAddress(RAX, RCX, TIMES_4, sizeof(RawArray)),
+                     RDX);
+  __ ret();
+  __ Bind(&fall_through);
   return false;
 }
 
 
+// Set length of growable object array.
+// On stack: growable array (+2), length (+1), return-address (+0).
 bool Intrinsifier::GrowableArray_setLength(Assembler* assembler) {
+  Label fall_through;
+  __ movq(RAX, Address(RSP, + 2 * kWordSize));  // Growable array.
+  __ movq(RCX, Address(RSP, + 1 * kWordSize));  // Length.
+  __ movq(RDX, FieldAddress(RAX, GrowableObjectArray::data_offset()));
+  __ cmpq(RCX, FieldAddress(RDX, Array::length_offset()));
+  __ j(ABOVE, &fall_through, Assembler::kNearJump);
+  __ movq(FieldAddress(RAX, GrowableObjectArray::length_offset()), RCX);
+  __ ret();
+  __ Bind(&fall_through);
   return false;
 }
 
 
 // Set data of growable object array.
 // On stack: growable array (+2), data (+1), return-address (+0).
 bool Intrinsifier::GrowableArray_setData(Assembler* assembler) {
   if (FLAG_enable_type_checks) {
     return false;
   }
@@ skipping 377 matching lines @@
 
 bool Intrinsifier::String_isEmpty(Assembler* assembler) {
   return false;
 }
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64