Remove the partially completed code for remote IsolateMirrors and

Remove the partially completed code for remote IsolateMirrors and
replace it with the beginnings of a local (same isolate) IsolateMirror
implementation.

Removed old mirror tests and added two new mirror tests.

Even though mirrors.cc is part of the vm, I chose to implement most of
it using the dart embedding interface instead of our internal
interfaces because the embedding interface was more convenient.
mirrors.cc is basically all new in this CL -- don't pay any attention
to diffs for that file.

Added dart embedding functions required for the functionality in this
CL: Dart_DebugName, Dart_GetNativeInstanceFieldCount,
Dart_RootLibrary, Dart_RegisteredLibraryUrls, and Dart_LibraryName.

Extended or modified some existing dart api functions, primarily to
make them propagate error handles properly.

Added tests for new dart embedding api functionality.

Added the ability to determine if a port is local to the current isolate.

Extended NotImplementedException to accept an optional string
argument.  I wanted to give more descriptive error messages.
Committed: https://code.google.com/p/dart/source/detail?r=8117

[turnidge, 2012-05-29 17:03:11]

Adding cshapiro as a reviewer.

[Ivan Posva, 2012-05-29 22:13:45]

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/include/da...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/include/da...
runtime/include/dart_api.h:2050: DART_EXPORT Dart_Handle
Dart_RegisteredLibraryUrls();
Is there an overlap with the debugging API here? Should we use the debugging API
for some of this mirror implementation?

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/include/da...
runtime/include/dart_api.h:2082: DART_EXPORT Dart_Handle
Dart_LibraryName(Dart_Handle library);
ditto (debugging API?)

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors.cc:316: Dart_Invoke(reflectee, member, invoke_args.length(),
invoke_args.data());
Dart_Invoke might want a sister function at some point which takes a Dart List
with the parameters. Maybe we should add that when we add support for named
arguments.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors_impl.dart:8: // handle private classes.
Is this still valid?

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors_impl.dart:15: class _LocalMirrorImpl implements Mirror {
abstract class maybe?

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors_impl.dart:35: class _LocalVMObjectMirrorImpl extends
_LocalMirrorImpl {
abstract class?

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors_impl.dart:45: class _LocalObjectMirrorImpl extends
_LocalVMObjectMirrorImpl
abstract class?

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/tests/vm/d...
File runtime/tests/vm/dart/isolate_mirror_local_test.dart (right):

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/tests/vm/d...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:54: rp.close();
Shouldn't you be closing rp inside the closure registered in then on the line
above to ensure the whole dispatch chain executes?

[turnidge, 2012-05-29 23:13:46]

Ready for another look.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/include/da...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/include/da...
runtime/include/dart_api.h:2050: DART_EXPORT Dart_Handle
Dart_RegisteredLibraryUrls();
On 2012/05/29 22:13:45, Ivan Posva wrote:
> Is there an overlap with the debugging API here? Should we use the debugging
API
> for some of this mirror implementation?

Switched the code to use Dart_GetLibraryUrls instead.  Moved my new unit test
over to debugger_impl_test.cc.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/include/da...
runtime/include/dart_api.h:2082: DART_EXPORT Dart_Handle
Dart_LibraryName(Dart_Handle library);
On 2012/05/29 22:13:45, Ivan Posva wrote:
> ditto (debugging API?)

Couldn't find this in the debugger api.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors.cc:316: Dart_Invoke(reflectee, member, invoke_args.length(),
invoke_args.data());
Yes.

On 2012/05/29 22:13:45, Ivan Posva wrote:
> Dart_Invoke might want a sister function at some point which takes a Dart List
> with the parameters. Maybe we should add that when we add support for named
> arguments.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors_impl.dart:8: // handle private classes.
On 2012/05/29 22:13:45, Ivan Posva wrote:
> Is this still valid?

Removed.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors_impl.dart:15: class _LocalMirrorImpl implements Mirror {
On 2012/05/29 22:13:45, Ivan Posva wrote:
> abstract class maybe?

Done.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors_impl.dart:35: class _LocalVMObjectMirrorImpl extends
_LocalMirrorImpl {
On 2012/05/29 22:13:45, Ivan Posva wrote:
> abstract class?

Done.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/lib/mirror...
runtime/lib/mirrors_impl.dart:45: class _LocalObjectMirrorImpl extends
_LocalVMObjectMirrorImpl
On 2012/05/29 22:13:45, Ivan Posva wrote:
> abstract class?

Done.

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/tests/vm/d...
File runtime/tests/vm/dart/isolate_mirror_local_test.dart (right):

https://chromiumcodereview.appspot.com/10416050/diff/13023/runtime/tests/vm/d...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:54: rp.close();
On 2012/05/29 22:13:45, Ivan Posva wrote:
> Shouldn't you be closing rp inside the closure registered in then on the line
> above to ensure the whole dispatch chain executes?

Done-ish.  I've moved the rp.close() into the last chained callback.  If I ever
add multiple leaf callbacks, I'll need to do some kind of join thing.

[Ivan Posva, 2012-05-29 23:31:27]

LGTM -ip