Remove the partially completed code for remote IsolateMirrors and

runtime/tests/vm/dart/isolate_mirror_local_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// Dart test program for checking implemention of IsolateMirror.
+// Dart test program for checking implemention of IsolateMirror when
+// inspecting the current isolate.
 
-#library('isolate_mirror_self_test');
+#library('isolate_mirror_local_test');
 
 #import('dart:isolate');
 #import('dart:mirrors');
 
 ReceivePort rp;
+int global_var = 0;
 
-void testIsolateMirror(port) {
-  isolateMirrorOf(port).then((IsolateMirror mirror) {
-      Expect.isTrue(mirror.debugName.contains("main"));
-      rp.close();
-    });
+// This function will be invoked reflectively.
+int function(int x) {
+  global_var = x;
+  return x + 1;
+}
+
+void testRootLibraryMirror(LibraryMirror lib_mirror) {
+  Expect.equals('isolate_mirror_local_test', lib_mirror.simpleName);
+  Expect.isTrue(lib_mirror.url.contains('isolate_mirror_local_test.dart'));
+
+  // Test library invocation.
+  Expect.equals(0, global_var);
+  lib_mirror.invoke('function', [ 123 ]).then(
+      (InstanceMirror retval) {
+        Expect.equals(123, global_var);
+        Expect.equals(124, retval.simpleValue);
+      });
+}
+
+void testLibrariesMap(Map libraries) {
+  // Just look for a couple of well-known libs.
+  LibraryMirror core_lib = libraries['dart:core'];
+  Expect.isTrue(core_lib is LibraryMirror);
+
+  LibraryMirror mirror_lib = libraries['dart:mirrors'];
+  Expect.isTrue(mirror_lib is LibraryMirror);
+}
+
+void testIsolateMirror(IsolateMirror mirror) {
+  Expect.isTrue(mirror.debugName.contains('main'));
+  testRootLibraryMirror(mirror.rootLibrary);
+  testLibrariesMap(mirror.libraries);
 }
 
 void main() {
-  // Test that I can reflect on myself.
+  // Test that an isolate can reflect on itself.
   rp = new ReceivePort();
-  testIsolateMirror(rp.toSendPort());
+  isolateMirrorOf(rp.toSendPort()).then(testIsolateMirror);
+  rp.close();

[Ivan Posva, 2012/05/29 22:13:45]

Shouldn't you be closing rp inside the closure registered in then on the line
above to ensure the whole dispatch chain executes?

[turnidge, 2012/05/29 23:13:47]

Done-ish.  I've moved the rp.close() into the last chained callback.  If I ever
add multiple leaf callbacks, I'll need to do some kind of join thing.

 }