Remove the partially completed code for remote IsolateMirrors and

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
+//
+// TODO(turnidge): Make Impl classes private when Dart_GetClass can
+// handle private classes.

[Ivan Posva, 2012/05/29 22:13:45]

Is this still valid?

[turnidge, 2012/05/29 23:13:47]

Removed.

 
-class _IsolateMirrorImpl implements IsolateMirror {
-  _IsolateMirrorImpl(this.port, this.debugName) {}
+// These values are allowed to be passed directly over the wire.
+bool isSimpleValue(var value) {
+  return (value === null || value is num || value is String || value is bool);
+}
 
-  final SendPort port;
+class _LocalMirrorImpl implements Mirror {

[Ivan Posva, 2012/05/29 22:13:45]

abstract class maybe?

[turnidge, 2012/05/29 23:13:47]

Done.

+  // Local mirrors always return the same IsolateMirror.  This field
+  // is more interesting once we implement remote mirrors.
+  IsolateMirror get isolate() { return Mirrors.localIsolateMirror(); }
+}
+
+class _LocalIsolateMirrorImpl extends _LocalMirrorImpl
+    implements IsolateMirror {
+  _LocalIsolateMirrorImpl(this.debugName, this.rootLibrary, this.libraries) {}
+
   final String debugName;
+  final LibraryMirror rootLibrary;
+  final Map<String, LibraryMirror> libraries;
+}
 
-  static _make(SendPort port, String debugName) {
-    return new _IsolateMirrorImpl(port, debugName);
+// A VMReference is used to hold a reference to a VM-internal object,
+// which can include things like libraries, classes, etc.
+class VMReference extends NativeFieldWrapperClass1 {
+}
+
+class _LocalVMObjectMirrorImpl extends _LocalMirrorImpl {

[Ivan Posva, 2012/05/29 22:13:45]

abstract class?

[turnidge, 2012/05/29 23:13:47]

Done.

+  _LocalVMObjectMirrorImpl(this._reference) {}
+
+  // For now, all VMObjects hold a VMReference.  We could consider
+  // storing the Object reference itself here if the object is a Dart
+  // language objects (except for objects of type VMReference, of
+  // course).
+  VMReference _reference;
+}
+
+class _LocalObjectMirrorImpl extends _LocalVMObjectMirrorImpl

[Ivan Posva, 2012/05/29 22:13:45]

abstract class?

[turnidge, 2012/05/29 23:13:47]

Done.

+    implements ObjectMirror {
+  _LocalObjectMirrorImpl(ref) : super(ref) {}
+
+  Future<InstanceMirror> invoke(String memberName,
+                                List<Object> positionalArguments,
+                                [Map<String,Object> namedArguments]) {
+    if (namedArguments !== null) {
+      throw new NotImplementedException('named arguments not implemented');
+    }
+    // Walk the arguments and make sure they are legal.
+    for (int i = 0; i < positionalArguments.length; i++) {
+      var arg = positionalArguments[i];
+      if (arg is Mirror) {
+        throw new MirrorException(
+            'positional argument $i ($arg) was not an InstanceMirror');
+      }
+      if (!isSimpleValue(arg)) {
+        throw new MirrorException(
+            'positional argument $i ($arg) was not a simple value');
+      }
+    }
+    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
+    completer.complete(
+        _invoke(this, memberName, positionalArguments));
+    return completer.future;
   }
+
+  static _invoke(ref, memberName, positionalArguments)
+      native 'LocalObjectMirrorImpl_invoke';
+}
+
+class _LocalInstanceMirrorImpl extends _LocalObjectMirrorImpl
+    implements InstanceMirror {
+  _LocalInstanceMirrorImpl(ref, this.simpleValue) : super(ref) {}
+
+  final simpleValue;
+}
+
+class _LocalLibraryMirrorImpl extends _LocalObjectMirrorImpl
+    implements LibraryMirror {
+  _LocalLibraryMirrorImpl(ref, this.simpleName, this.url) : super(ref) {}
+
+  final String simpleName;
+  final String url;
 }
 
 class _Mirrors {
+  // Does a port refer to our local isolate?
+  static bool isLocalPort(SendPort port) native 'Mirrors_isLocalPort';
+
+  static IsolateMirror _localIsolateMirror;
+
+  // The IsolateMirror for the current isolate.
+  static IsolateMirror localIsolateMirror() {
+    if (_localIsolateMirror === null) {
+      _localIsolateMirror = makeLocalIsolateMirror();
+    }
+    return _localIsolateMirror;
+  }
+
+  // Creates a new local IsolateMirror.
+  static bool makeLocalIsolateMirror()
+      native 'Mirrors_makeLocalIsolateMirror';
+
   static Future<IsolateMirror> isolateMirrorOf(SendPort port) {
     Completer<IsolateMirror> completer = new Completer<IsolateMirror>();
-    String request = '{ "command": "isolateMirrorOf" }';
-    ReceivePort rp = new ReceivePort();
-    if (!send(port, request, rp.toSendPort())) {
-      throw new Exception("Unable to send mirror request to port $port");
+    if (isLocalPort(port)) {
+      // Make a local isolate mirror.
+      completer.complete(localIsolateMirror());
+    } else {
+      // Make a remote isolate mirror.
+      throw new NotImplementedException('Remote mirrors not yet implemented');
     }
-    rp.receive((message, _) {
-        rp.close();
-        completer.complete(_Mirrors.processResponse(
-            port, "isolateMirrorOf", message));
-      });
     return completer.future;
   }
-
-  static bool send(SendPort port, String request, SendPort replyTo)
-      native "Mirrors_send";
-
-  static processResponse(SendPort port, String command, String response)
-      native "Mirrors_processResponse";
 }