Issue 10388084: Better support for the case of typed arrays inheriting from other typed arrays.

Issue 10388084: Better support for the case of typed arrays inheriting from other typed arrays. (Closed)

Created:
8 years, 7 months ago by Anton Muhin

Modified:
8 years, 7 months ago

Reviewers:
podivilov, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Better support for the case of typed arrays inheriting from other typed arrays. R=podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=7580

Patch Set 2 : Next iteration #

Patch Set 3 : Next iteration #

Patch Set 5 : Removing unused local #

Patch Set 6 : better comment #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -303 lines)			Patch
M	lib/dom/dom.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	1 2 3	2 chunks	+2 lines, -93 lines	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	lib/dom/scripts/dartgenerator.py	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	lib/dom/scripts/generator.py	View	1	2 chunks	+38 lines, -1 line	0 comments	Download
M	lib/dom/scripts/systemfrog.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	1 2 3	4 chunks	+10 lines, -7 lines	0 comments	Download
M	lib/dom/scripts/systeminterface.py	View	1	5 chunks	+8 lines, -3 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	1 2 3 4 5	3 chunks	+25 lines, -3 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		2 chunks	+2 lines, -92 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		2 chunks	+2 lines, -93 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm with comment. https://chromiumcodereview.appspot.com/10388084/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10388084/diff/1/lib/dom/scripts/systemnative.py#newcode250 lib/dom/scripts/systemnative.py:250: # Ugly corner case: in WebKit ...

8 years, 7 months ago (2012-05-11 12:34:43 UTC) #2

podivilov

https://chromiumcodereview.appspot.com/10388084/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10388084/diff/1/lib/dom/scripts/systemnative.py#newcode250 lib/dom/scripts/systemnative.py:250: # Ugly corner case: in WebKit Uint8ClampedArray inherits from ...

8 years, 7 months ago (2012-05-11 14:18:17 UTC) #3

podivilov

lgtm https://chromiumcodereview.appspot.com/10388084/diff/13/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10388084/diff/13/lib/dom/scripts/generator.py#newcode94 lib/dom/scripts/generator.py:94: inherits indexer and may just reuse it.""" Maybe ...

8 years, 7 months ago (2012-05-12 08:35:10 UTC) #5

Anton Muhin

Thanks a lot for review, Pavel. I also need https://chromiumcodereview.appspot.com/10356141/ to land this one. https://chromiumcodereview.appspot.com/10388084/diff/13/lib/dom/scripts/generator.py ...

8 years, 7 months ago (2012-05-12 08:37:03 UTC) #6

podivilov

8 years, 7 months ago (2012-05-12 08:39:06 UTC) #7

https://chromiumcodereview.appspot.com/10388084/diff/13/lib/dom/scripts/gener...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10388084/diff/13/lib/dom/scripts/gener...
lib/dom/scripts/generator.py:94: inherits indexer and may just reuse it."""
On 2012/05/12 08:37:03, antonmuhin wrote:
> Not sure, let's keep it generic: I don't think that generator should go into
> details which of systems needs this knowledge.
> 
> On 2012/05/12 08:35:10, podivilov wrote:
> > Maybe mention that it is needed to override indexed accessors for native
> > implementation?
> 

I just think that a note about why it is __really__ needed would be very helpful
for the reader.

Expand Messages | Collapse Messages