Better support for the case of typed arrays inheriting from other typed arrays.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 229 matching lines @@
     self._class_name = self._ImplClassName(self._interface.id)
     self._interface_type_info = GetIDLTypeInfo(self._interface.id)
     self._members_emitter = emitter.Emitter()
     self._cpp_declarations_emitter = emitter.Emitter()
     self._cpp_impl_includes = set()
     self._cpp_definitions_emitter = emitter.Emitter()
     self._cpp_resolver_emitter = emitter.Emitter()
 
     self._GenerateConstructors()
 
+    # Ugly corner case: in WebKit Uint8ClampedArray inherits from Uint8Array,

[podivilov, 2012/05/11 12:34:44]

Please use AddIndexer. Looks like we need to fork DartGenerator for native
system to implement it properly.

[podivilov, 2012/05/11 14:18:17]

Done.

+    # but Uint8Array::{g,s}et is not virtual, so one needs to have an override
+    # for operator[] and operator[]= for Uint8ClampedArray.
+    if self._interface.id == 'Uint8ClampedArray':
+      self._EmitNativeIndexGetter(self._interface, 'int')
+      self._EmitNativeIndexSetter(self._interface, 'int')
+
   def _GenerateConstructors(self):
     if not self._IsConstructable():
       return
 
     # TODO(antonm): currently we don't have information about number of arguments expected by
     # the constructor, so name only dispatch.
     self._cpp_resolver_emitter.Emit(
         '    if (name == "$(INTERFACE_NAME)_constructor_Callback")\n'
         '        return Dart$(INTERFACE_NAME)Internal::constructorCallback;\n',
         INTERFACE_NAME=self._interface.id)
@@ skipping 582 matching lines @@
 def _InstanceOfNode(database, interface):
   if interface.id == 'Node':
     return True
   for parent in interface.parents:
     if not database.HasInterface(parent.type.id):
       continue
     parent_interface = database.GetInterface(parent.type.id)
     if _InstanceOfNode(database, parent_interface):
       return True
   return False