Better support for the case of typed arrays inheriting from other typed arrays.

lib/dom/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import re
 
@@ skipping 67 matching lines @@
     'IDBCursor.continueFunction':
       """
         if (key == null) return this['continue']();
         return this['continue'](key);
       """,
 }
 
 def IsPrimitiveType(type_name):
   return isinstance(GetIDLTypeInfo(type_name), PrimitiveIDLTypeInfo)
 
+def ListImplementationInfo(interface, database):
+  """Returns a tuple (elment_type, requires_indexer).
+  If interface do not have to implement List, element_type is None.
+  Otherwise element_type is list element type and requires_indexer
+  is true iff this interface implementation must have indexer and
+  false otherwise.  False means that interface implementation
+  inherits indexer and may just reuse it."""

[podivilov, 2012/05/12 08:35:10]

Maybe mention that it is needed to override indexed accessors for native
implementation?

[Anton Muhin, 2012/05/12 08:37:03]

Not sure, let's keep it generic: I don't think that generator should go into
details which of systems needs this knowledge.

On 2012/05/12 08:35:10, podivilov wrote:

[podivilov, 2012/05/12 08:39:06]

I just think that a note about why it is __really__ needed would be very helpful
for the reader.

+  element_type = MaybeListElementType(interface)
+  if element_type:
+    return (element_type, True)
+
+  for parent in interface.parents:
+    if database.HasInterface(parent.type.id):
+      parent_interface = database.GetInterface(parent.type.id)
+      (element_type, _) = ListImplementationInfo(parent_interface, database)
+      if element_type:
+        return (element_type, False)
+
+  return (None, None)
+
+
 def MaybeListElementTypeName(type_name):
   """Returns the List element type T from string of form "List<T>", or None."""
   match = re.match(r'sequence<(\w*)>$', type_name)
   if match:
     return match.group(1)
   return None
 
 def MaybeListElementType(interface):
   """Returns the List element type T, or None in interface does not implement
   List<T>.
   """
   for parent in interface.parents:
     element_type = MaybeListElementTypeName(parent.type.id)
     if element_type:
       return element_type
   return None
 
 def MaybeTypedArrayElementType(interface):
   """Returns the typed array element type, or None in interface is not a
   TypedArray.
   """
   # Typed arrays implement ArrayBufferView and List<T>.
   for parent in interface.parents:
-    if  parent.type.id == 'ArrayBufferView':
+    if parent.type.id == 'ArrayBufferView':
       return MaybeListElementType(interface)
   return None
 
+def MaybeTypedArrayElementTypeInHierarchy(interface, database):
+  """Returns the typed array element type, or None in interface is not a
+  TypedArray.  Checks the whole parent hierarchy.
+  """
+  element_type = MaybeTypedArrayElementType(interface)
+  if element_type:
+    return element_type
+  for parent in interface.parents:
+    if database.HasInterface(parent.type.id):
+      parent_interface = database.GetInterface(parent.type.id)
+      element_type = MaybeTypedArrayElementType(parent_interface)
+      if element_type:
+        return element_type
+
+  return None
+
 def MakeNativeSpec(javascript_binding_name):
   if javascript_binding_name in _frog_dom_custom_native_specs:
     return _frog_dom_custom_native_specs[javascript_binding_name]
   else:
     # Make the class 'hidden' so it is dynamically patched at runtime.  This
     # is useful not only for browser compat, but to allow code that links
     # against dart:dom to load in a worker isolate.
     return '*' + javascript_binding_name
 
 
@@ skipping 594 matching lines @@
     '"SVGAnimatedListPropertyTearOff.h"',
     '"SVGTransformListPropertyTearOff.h"',
     '"SVGPathSegListPropertyTearOff.h"',
 ]
 
 def GetIDLTypeInfo(idl_type_name):
   match = re.match(r'sequence<(\w+)>$', idl_type_name)
   if match:
     return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
   return _idl_type_registry.get(idl_type_name, IDLTypeInfo(idl_type_name))