Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 10379018: Revert "Revert "Implement {Int,Uint}{8,16,32,64} and Float{32,64} typed arrays."" (Closed)

Created:
8 years, 7 months ago by cshapiro
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Revert "Implement {Int,Uint}{8,16,32,64} and Float{32,64} typed arrays."" This reverts commit 63480a81fccbde001494dd535cd06a8fa02ed261. Committed: https://code.google.com/p/dart/source/detail?r=7352

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8019 lines, -1281 lines) Patch
M runtime/bin/buffer_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dartutils.h View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/file.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/file_impl.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/http_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/http_parser.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/socket_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_stream_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/string_stream.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +1 line, -1 line 3 comments Download
M runtime/lib/byte_array.cc View 2 chunks +445 lines, -139 lines 0 comments Download
M runtime/lib/byte_array.dart View 2 chunks +2163 lines, -288 lines 0 comments Download
A runtime/tests/vm/dart/byte_array_test.dart View 1 chunk +2177 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +70 lines, -41 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 3 chunks +59 lines, -7 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 8 chunks +49 lines, -49 lines 0 comments Download
M runtime/vm/dart_api_message.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_message.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +976 lines, -91 lines 0 comments Download
M runtime/vm/object.cc View 11 chunks +675 lines, -78 lines 0 comments Download
M runtime/vm/object_store.h View 3 chunks +174 lines, -12 lines 0 comments Download
M runtime/vm/object_store.cc View 3 chunks +80 lines, -8 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +234 lines, -411 lines 0 comments Download
M runtime/vm/raw_object.h View 4 chunks +165 lines, -14 lines 0 comments Download
M runtime/vm/raw_object.cc View 2 chunks +244 lines, -10 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +451 lines, -19 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M tests/standalone/byte_array_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
https://chromiumcodereview.appspot.com/10379018/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://chromiumcodereview.appspot.com/10379018/diff/1/runtime/include/dart_api.h#newcode695 runtime/include/dart_api.h:695: kUint8Array, This name has been changed, but the as_byte_array ...
8 years, 7 months ago (2012-05-07 13:14:59 UTC) #1
Søren Gjesse
https://chromiumcodereview.appspot.com/10379018/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://chromiumcodereview.appspot.com/10379018/diff/1/runtime/include/dart_api.h#newcode695 runtime/include/dart_api.h:695: kUint8Array, On 2012/05/07 13:14:59, Bill Hesse wrote: > This ...
8 years, 7 months ago (2012-05-07 14:06:18 UTC) #2
Søren Gjesse
8 years, 7 months ago (2012-05-07 14:11:54 UTC) #3
https://chromiumcodereview.appspot.com/10379018/diff/1/runtime/include/dart_a...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/10379018/diff/1/runtime/include/dart_a...
runtime/include/dart_api.h:695: kUint8Array,
On 2012/05/07 14:06:18, Søren Gjesse wrote:
> On 2012/05/07 13:14:59, Bill Hesse wrote:
> > This name has been changed, but the as_byte_array union member below has not
> had
> > its name changed.
> > Is this what we want?
> 
> As far as I can see we need to support all of the types 
> 
> kInt8Array
> kUint8Array
> kInt16Array
> kUint16Array
> kInt32Array
> kUint32Array
> kInt64Array
> kUint64Array
> kFloat32Array
> kFloat64Array
> kExternalInt8Array
> kExternalUint8Array
> kExternalInt16Array
> kExternalUint16Array
> kExternalInt32Array
> kExternalUint32Array
> kExternalInt64Array
> kExternalUint64Array
> kExternalFloat32Array
> kExternalFloat64Array
> 
> in the native port serialization. On to of this list we should also support
> external and not-external.
> 
> That is a huge number of types, but if we want the deserialization on the Dart
> side to be able to get all these types - maybe backed by an external byte
array
> - we need to handle all of them.

Opened http://code.google.com/p/dart/issues/detail?id=2917.

Powered by Google App Engine
This is Rietveld 408576698