Revert "Revert "Implement {Int,Uint}{8,16,32,64} and Float{32,64} typed arrays.""

runtime/vm/dart_api_message.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart_api_message.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 
 namespace dart {
 
@@ skipping 104 matching lines @@
   Dart_CObject* value =
       reinterpret_cast<Dart_CObject*>(
           alloc_(NULL, 0, sizeof(Dart_CObject) + length + 1));
   ASSERT(value != NULL);
   value->value.as_string = reinterpret_cast<char*>(value) + sizeof(*value);
   value->type = Dart_CObject::kString;
   return value;
 }
 
 
-Dart_CObject* ApiMessageReader::AllocateDartCObjectByteArray(intptr_t length) {
+Dart_CObject* ApiMessageReader::AllocateDartCObjectUint8Array(intptr_t length) {
   // Allocate a Dart_CObject structure followed by an array of bytes
   // for the byte array content. The pointer to the byte array content
   // is set up to this area.
   Dart_CObject* value =
       reinterpret_cast<Dart_CObject*>(
           alloc_(NULL, 0, sizeof(Dart_CObject) + length));
   ASSERT(value != NULL);
-  value->type = Dart_CObject::kByteArray;
+  value->type = Dart_CObject::kUint8Array;
   value->value.as_array.length = length;
   if (length > 0) {
     value->value.as_byte_array.values =
         reinterpret_cast<uint8_t*>(value) + sizeof(*value);
   } else {
     value->value.as_byte_array.values = NULL;
   }
   return value;
 }
 
@@ skipping 125 matching lines @@
       }
       p[len] = '\0';
       return object;
     }
     case ObjectStore::kTwoByteStringClass:
       // Two byte strings not supported.
       return NULL;
     case ObjectStore::kFourByteStringClass:
       // Four byte strings not supported.
       return NULL;
-    case ObjectStore::kInternalByteArrayClass: {
+    case ObjectStore::kUint8ArrayClass: {
       intptr_t len = ReadSmiValue();
-      Dart_CObject* object = AllocateDartCObjectByteArray(len);
+      Dart_CObject* object = AllocateDartCObjectUint8Array(len);
       AddBackwardReference(object_id, object);
       if (len > 0) {
         uint8_t* p = object->value.as_byte_array.values;
         for (intptr_t i = 0; i < len; i++) {
           p[i] = Read<uint8_t>();
         }
       }
       return object;
     }
     default:
       // Everything else not supported.
       return NULL;
   }
 }
 
 
 Dart_CObject* ApiMessageReader::ReadIndexedObject(intptr_t object_id) {
   if (object_id == Object::kNullObject) {
     return AllocateDartCObjectNull();
   } else if (object_id == ObjectStore::kTrueValue) {
     return AllocateDartCObjectBool(true);
   } else if (object_id == ObjectStore::kFalseValue) {
     return AllocateDartCObjectBool(false);
   } else if (object_id == ObjectStore::kDynamicType ||
              object_id == ObjectStore::kDoubleInterface ||
              object_id == ObjectStore::kIntInterface ||
              object_id == ObjectStore::kBoolInterface ||
-             object_id == ObjectStore::kStringInterface ||
-             object_id == ObjectStore::kByteArrayInterface) {
+             object_id == ObjectStore::kStringInterface) {
     // Always return dynamic type (this is only a marker).
     return &dynamic_type_marker;
   } else {
     intptr_t index = object_id - kMaxPredefinedObjectIds;
     ASSERT((0 <= index) && (index < backward_references_.length()));
     ASSERT(backward_references_[index] != NULL);
     return backward_references_[index];
   }
   return NULL;
 }
@@ skipping 211 matching lines @@
       WriteObjectHeader(ObjectStore::kArrayClass, 0);
       WriteSmi(object->value.as_array.length);
       // Write out the type arguments.
       WriteIndexedObject(Object::kNullObject);
       // Write out array elements.
       for (int i = 0; i < object->value.as_array.length; i++) {
         WriteCObject(object->value.as_array.values[i]);
       }
       break;
     }
-    case Dart_CObject::kByteArray: {
+    case Dart_CObject::kUint8Array: {
       // Write out the serialization header value for this object.
       WriteInlinedHeader(object);
       // Write out the class and tags information.
-      WriteObjectHeader(ObjectStore::kInternalByteArrayClass, 0);
+      WriteObjectHeader(ObjectStore::kUint8ArrayClass, 0);
       uint8_t* bytes = object->value.as_byte_array.values;
       intptr_t len = object->value.as_byte_array.length;
       WriteSmi(len);
       for (intptr_t i = 0; i < len; i++) {
         Write<uint8_t>(bytes[i]);
       }
       break;
     }
     default:
       UNREACHABLE();
   }
 }
 
 
 void ApiMessageWriter::WriteCMessage(Dart_CObject* object) {
   WriteCObject(object);
   UnmarkAllCObjects(object);
   FinalizeBuffer();
 }
 
 }  // namespace dart