Revert "Revert "Implement {Int,Uint}{8,16,32,64} and Float{32,64} typed arrays.""

runtime/vm/snapshot_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
@@ skipping 74 matching lines @@
       break;
     case Dart_CObject::kBigint:
       EXPECT_STREQ(first->value.as_bigint, second->value.as_bigint);
       break;
     case Dart_CObject::kDouble:
       EXPECT_EQ(first->value.as_double, second->value.as_double);
       break;
     case Dart_CObject::kString:
       EXPECT_STREQ(first->value.as_string, second->value.as_string);
       break;
-    case Dart_CObject::kByteArray:
+    case Dart_CObject::kUint8Array:
       EXPECT_EQ(first->value.as_byte_array.length,
                 second->value.as_byte_array.length);
       for (int i = 0; i < first->value.as_byte_array.length; i++) {
         EXPECT_EQ(first->value.as_byte_array.values[i],
                   second->value.as_byte_array.values[i]);
       }
       break;
     case Dart_CObject::kArray:
       // Use invalid type as a visited marker to avoid infinite
       // recursion on graphs with cycles.
@@ skipping 542 matching lines @@
 }
 
 
 TEST_CASE(SerializeByteArray) {
   Zone zone(Isolate::Current());
 
   // Write snapshot with object content.
   uint8_t* buffer;
   SnapshotWriter writer(Snapshot::kMessage, &buffer, &zone_allocator);
   const int kByteArrayLength = 256;
-  InternalByteArray& byte_array =
-      InternalByteArray::Handle(InternalByteArray::New(kByteArrayLength));
+  Uint8Array& byte_array =
+      Uint8Array::Handle(Uint8Array::New(kByteArrayLength));
   for (int i = 0; i < kByteArrayLength; i++) {
-    byte_array.SetAt<uint8_t>(i, i);
+    byte_array.SetAt(i, i);
   }
   writer.WriteObject(byte_array.raw());
   writer.FinalizeBuffer();
 
   // Create a snapshot object using the buffer.
   const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
 
   // Read object back from the snapshot.
   SnapshotReader reader(snapshot, Isolate::Current());
   ByteArray& serialized_byte_array = ByteArray::Handle();
   serialized_byte_array ^= reader.ReadObject();
   EXPECT(serialized_byte_array.IsByteArray());
 
   // Read object back from the snapshot into a C structure.
   ApiNativeScope scope;
   Dart_CObject* root = DecodeMessage(buffer + Snapshot::kHeaderSize,
                                      writer.BytesWritten(),
                                      &zone_allocator);
-  EXPECT_EQ(Dart_CObject::kByteArray, root->type);
+  EXPECT_EQ(Dart_CObject::kUint8Array, root->type);
   EXPECT_EQ(kByteArrayLength, root->value.as_byte_array.length);
   for (int i = 0; i < kByteArrayLength; i++) {
     EXPECT(root->value.as_byte_array.values[i] == i);
   }
   CheckEncodeDecodeMessage(root);
 }
 
 
 TEST_CASE(SerializeEmptyByteArray) {
   Zone zone(Isolate::Current());
 
   // Write snapshot with object content.
   uint8_t* buffer;
   SnapshotWriter writer(Snapshot::kMessage, &buffer, &zone_allocator);
   const int kByteArrayLength = 0;
-  InternalByteArray& byte_array =
-      InternalByteArray::Handle(InternalByteArray::New(kByteArrayLength));
+  Uint8Array& byte_array =
+      Uint8Array::Handle(Uint8Array::New(kByteArrayLength));
   writer.WriteObject(byte_array.raw());
   writer.FinalizeBuffer();
 
   // Create a snapshot object using the buffer.
   const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
 
   // Read object back from the snapshot.
   SnapshotReader reader(snapshot, Isolate::Current());
   ByteArray& serialized_byte_array = ByteArray::Handle();
   serialized_byte_array ^= reader.ReadObject();
   EXPECT(serialized_byte_array.IsByteArray());
 
   // Read object back from the snapshot into a C structure.
   ApiNativeScope scope;
   Dart_CObject* root = DecodeMessage(buffer + Snapshot::kHeaderSize,
                                      writer.BytesWritten(),
                                      &zone_allocator);
-  EXPECT_EQ(Dart_CObject::kByteArray, root->type);
+  EXPECT_EQ(Dart_CObject::kUint8Array, root->type);
   EXPECT_EQ(kByteArrayLength, root->value.as_byte_array.length);
   EXPECT(root->value.as_byte_array.values == NULL);
   CheckEncodeDecodeMessage(root);
 }
 
 
 TEST_CASE(SerializeScript) {
   const char* kScriptChars =
       "class A {\n"
       "  static bar() { return 42; }\n"
@@ skipping 571 matching lines @@
       "  for (var i = 0; i < kArrayLength; i++) list[i] = bigint;\n"
       "  return list;\n"
       "}\n"
       "getDoubleList() {\n"
       "  var d = 3.14;\n"
       "  var list = new List<double>(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) list[i] = d;\n"
       "  return list;\n"
       "}\n"
       "getByteArrayList() {\n"
-      "  var byte_array = new ByteArray(256);\n"
-      "  var list = new List<ByteArray>(kArrayLength);\n"
+      "  var byte_array = new Uint8List(256);\n"
+      "  var list = new List(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) list[i] = byte_array;\n"
       "  return list;\n"
       "}\n"
       "getMixedList() {\n"
       "  var list = new List(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) {\n"
       "    list[i] = ((i % 2) == 0) ? 'A' : 2.72;\n"
       "  }\n"
       "  return list;\n"
       "}\n"
@@ skipping 73 matching lines @@
     {
       // Generate a list of doubles from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getByteArrayList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject::kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       for (int i = 0; i < kArrayLength; i++) {
         Dart_CObject* element = root->value.as_array.values[i];
         EXPECT_EQ(root->value.as_array.values[0], element);
-        EXPECT_EQ(Dart_CObject::kByteArray, element->type);
+        EXPECT_EQ(Dart_CObject::kUint8Array, element->type);
         EXPECT_EQ(256, element->value.as_byte_array.length);
       }
     }
     {
       // Generate a list of objects of different types from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getMixedList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject::kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
@@ skipping 119 matching lines @@
   EXPECT(Dart_ErrorHasException(result));
   EXPECT_SUBSTRING("Exception: nulltruefalse1234563.14[]100123456789\n",
                    Dart_GetError(result));
 
   Dart_ExitScope();
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart