Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10351011: Change Platform members to getters instead of methods. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)
Modified:
8 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change Platform members to getters instead of methods. R=sgjesse@google.com BUG=dartbug.com/1668 TEST= Committed: https://code.google.com/p/dart/source/detail?r=7282

Patch Set 1 #

Patch Set 2 : Adding new test binaries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -92 lines) Patch
M lib/compiler/implementation/filenames.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/io.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M runtime/bin/platform.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/platform_impl.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/process_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/dart_std_io_pipe_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_error_test.dart View 5 chunks +15 lines, -15 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/file_error_test.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 6 chunks +12 lines, -12 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/standalone/io/print_env.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_environment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_test_util.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/bin/linux/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/macos/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/windows/dart.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/dart/multitest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_options.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M utils/compiler/build_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
This will need an update of the stable test binaries as well. I will update ...
8 years, 7 months ago (2012-05-03 12:26:56 UTC) #1
Søren Gjesse
8 years, 7 months ago (2012-05-03 12:54:33 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698