Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: tools/testing/dart/test_options.dart

Issue 10351011: Change Platform members to getters instead of methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Adding new test binaries Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index ad6a73ededce86f33a0b8550e2e4fb6435dffb7e..8622a6fece8c6d1c077814d0e06bd7bdcc4e469a 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -113,7 +113,7 @@ is 'dart file.dart' and you specify special command
'The operating system to run tests on',
['-s', '--system'],
['linux', 'macos', 'windows'],
- Platform.operatingSystem()),
+ Platform.operatingSystem),
new _TestOptionSpecification(
'checked',
'Run tests in checked mode',
@@ -154,7 +154,7 @@ is 'dart file.dart' and you specify special command
'The number of parallel tasks to run',
['-j', '--tasks'],
[],
- Platform.numberOfProcessors(),
+ Platform.numberOfProcessors,
'int'),
new _TestOptionSpecification(
'shards',
@@ -418,7 +418,7 @@ Note: currently only implemented for dart2js.''',
"${config['runtime']} is invalid. Skipping this combination.");
}
if (config['runtime'] == 'ie' &&
- Platform.operatingSystem() != 'windows') {
+ Platform.operatingSystem != 'windows') {
isValid = false;
print("Warning cannot run Internet Explorer on non-Windows operating" +
" system.");
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698