Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: tests/standalone/io/process_test_util.dart

Issue 10351011: Change Platform members to getters instead of methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Adding new test binaries Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/standalone/io/process_environment_test.dart ('k') | tools/testing/bin/linux/dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 String getPlatformOutDir() { 5 String getPlatformOutDir() {
6 var os = Platform.operatingSystem(); 6 var os = Platform.operatingSystem;
7 if (os == 'linux') return 'out/'; 7 if (os == 'linux') return 'out/';
8 if (os == 'macos') return 'xcodebuild/'; 8 if (os == 'macos') return 'xcodebuild/';
9 return ''; // Windows. 9 return ''; // Windows.
10 } 10 }
11 11
12 String getPlatformExecutableExtension() { 12 String getPlatformExecutableExtension() {
13 var os = Platform.operatingSystem(); 13 var os = Platform.operatingSystem;
14 if (os == 'windows') return '.exe'; 14 if (os == 'windows') return '.exe';
15 return ''; // Linux and Mac OS. 15 return ''; // Linux and Mac OS.
16 } 16 }
17 17
18 String getProcessTestFileName() { 18 String getProcessTestFileName() {
19 var outDir = getPlatformOutDir(); 19 var outDir = getPlatformOutDir();
20 var extension = getPlatformExecutableExtension(); 20 var extension = getPlatformExecutableExtension();
21 // We do not expose information about the mode or architecture we are testing 21 // We do not expose information about the mode or architecture we are testing
22 // to the tests themselves, so we use any working copy. 22 // to the tests themselves, so we use any working copy.
23 var names = ['${outDir}Release_ia32/process_test$extension', 23 var names = ['${outDir}Release_ia32/process_test$extension',
(...skipping 19 matching lines...) Expand all
43 '${outDir}Release_x64/dart$extension', 43 '${outDir}Release_x64/dart$extension',
44 '${outDir}Debug_x64/dart$extension']; 44 '${outDir}Debug_x64/dart$extension'];
45 45
46 for (var name in names) { 46 for (var name in names) {
47 if (new File(name).existsSync()) { 47 if (new File(name).existsSync()) {
48 return name; 48 return name;
49 } 49 }
50 } 50 }
51 Expect.fail('Could not find the dart executable.'); 51 Expect.fail('Could not find the dart executable.');
52 } 52 }
OLDNEW
« no previous file with comments | « tests/standalone/io/process_environment_test.dart ('k') | tools/testing/bin/linux/dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698