reenable some dartc tests that have been disabled accidentally. Move

reenable some dartc tests that have been disabled accidentally. Move
client/dartc/ to samples/dartc/.

Committed: https://code.google.com/p/dart/source/detail?r=7262

[Siggi Cherem (dart-lang), 2012-05-02 22:28:28]

I'm not sure who to ask, so I'm cc'ing a couple people.

Do we still need the DartcCompilationTests? I moved them from client to samples
(client is now empty, and most code that was tested there is now in samples).

[Emily Fortuna, 2012-05-02 22:34:41]

lgtm? Hopefully we'll hear back from someone else cc'd, too.

https://chromiumcodereview.appspot.com/10343008/diff/2002/tools/test.dart
File tools/test.dart (left):

https://chromiumcodereview.appspot.com/10343008/diff/2002/tools/test.dart#old...
tools/test.dart:113: } else if (conf['compiler'] == 'dartc' && key == 'dartc') {
wow, this is kindof hilarious.

[ahe, 2012-05-03 09:11:56]

LGTM!

I think these tests are crucial for the IDE to work well, so nice catch, Siggi.

Cheers,
Peter

[Bill Hesse, 2012-05-03 14:44:03]

LGTM.

https://chromiumcodereview.appspot.com/10343008/diff/2002/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10343008/diff/2002/tools/testing/dart/...
tools/testing/dart/test_suite.dart:384: testName = filename;
I don't like the possibility that we might hit this case in standard test
suites.  Can we print a warning here?

[Siggi Cherem (dart-lang), 2012-05-04 23:51:24]

https://chromiumcodereview.appspot.com/10343008/diff/2002/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10343008/diff/2002/tools/testing/dart/...
tools/testing/dart/test_suite.dart:384: testName = filename;
On 2012/05/03 14:44:04, Bill Hesse wrote:
> I don't like the possibility that we might hit this case in standard test
> suites.  Can we print a warning here?

maybe we can split the dartc vs non-dartc cases upfront so we don't mix this
branch with 2 different patterns?