reenable some dartc tests that have been disabled accidentally. Move

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 351 matching lines @@
     if (start > testsStart) {
       // TODO(sigmund): delete this branch once all tests stop using the src/
       // directory
       testName = filename.substring(start + 4, filename.length - 5);
     } else if (optionsFromFile['isMultitest']) {
       start = filename.lastIndexOf('/');
       int middle = filename.lastIndexOf('_');
       testName = filename.substring(start + 1, middle) + '/' +
           filename.substring(middle + 1, filename.length - 5);
     } else {
-      // This case is hit by the dartc client compilation
-      // tests. These tests are pretty broken compared to the
+      // This branch is hit in two cases: standard test suites created with
+      // forDirectory and dartc code compilation tests.
+
+      // Dartc compilation tests are pretty broken compared to the
       // rest. They use the .dart suffix in the status files. They
       // find tests in weird ways (testing that they contain "#").
       // They need to be redone.
       // TODO(1058): This does not work on Windows.
       start = filename.indexOf(directoryPath);
       if (start != -1) {
         testName = filename.substring(start + directoryPath.length + 1);
       } else {
         testName = filename;

[Bill Hesse, 2012/05/03 14:44:04]

I don't like the possibility that we might hit this case in standard test
suites.  Can we print a warning here?

[Siggi Cherem (dart-lang), 2012/05/04 23:51:24]

maybe we can split the dartc vs non-dartc cases upfront so we don't mix this
branch with 2 different patterns?

       }
 
       if (configuration['compiler'] != 'dartc' ||
           testName.endsWith('_test.dart')) {
         if (testName.endsWith('.dart')) {
           testName = testName.substring(0, testName.length - 5);
         }
       }
     }
     int shards = configuration['shards'];
@@ skipping 747 matching lines @@
   void createTest(successIgnored) {
     var sdkDir = "$buildDir/dart-sdk".trim();
     List<String> args = <String>[
         '-ea',
         '-classpath', classPath,
         '-Dcom.google.dart.sdk=$sdkDir',
         '-Dcom.google.dart.corelib.SharedTests.test_py=' +
             dartDir + '/tools/test.py',
         'org.junit.runner.JUnitCore'];
     args.addAll(testClasses);
-    
+
     // Lengthen the timeout for JUnit tests.  It is normal for them
     // to run for a few minutes.
     Map updatedConfiguration = new Map();
     configuration.forEach((key, value) {
       updatedConfiguration[key] = value;
     });
     updatedConfiguration['timeout'] *= 2;
     doTest(new TestCase(suiteName,
                         [new Command('java', args)],
                         updatedConfiguration,
@@ skipping 236 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }