Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 10343008: reenable some dartc tests that have been disabled accidentally. Move (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/test.dart ('K') | « tools/test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index d7706f3760a5eee52d43d30e62a4fe1026bf2f0c..b1b726af804abff2dffcaa3380f6cc13b0d88d26 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -369,8 +369,10 @@ class StandardTestSuite implements TestSuite {
testName = filename.substring(start + 1, middle) + '/' +
filename.substring(middle + 1, filename.length - 5);
} else {
- // This case is hit by the dartc client compilation
- // tests. These tests are pretty broken compared to the
+ // This branch is hit in two cases: standard test suites created with
+ // forDirectory and dartc code compilation tests.
+
+ // Dartc compilation tests are pretty broken compared to the
// rest. They use the .dart suffix in the status files. They
// find tests in weird ways (testing that they contain "#").
// They need to be redone.
@@ -1147,7 +1149,7 @@ class JUnitTestSuite implements TestSuite {
dartDir + '/tools/test.py',
'org.junit.runner.JUnitCore'];
args.addAll(testClasses);
-
+
// Lengthen the timeout for JUnit tests. It is normal for them
// to run for a few minutes.
Map updatedConfiguration = new Map();
« tools/test.dart ('K') | « tools/test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698