Issue 10283003: - Fix another side effect issue: never add AstNode to sequence unless they are a statement. Added t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10283003: - Fix another side effect issue: never add AstNode to sequence unless they are a statement. Added t… (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix another side effect issue: never add AstNode to sequence unless they are a statement. Added tests. LoadLocal has now an optional pseudo input. Committed: https://code.google.com/p/dart/source/detail?r=7210

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -15 lines)			Patch
M	runtime/vm/ast.h	View		2 chunks	+15 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View		4 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/parser.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	tests/language/compound_assignment_operator_test.dart	View	1	2 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nice. lgtm.

Expand Messages | Collapse Messages