- Fix another side effect issue: never add AstNode to sequence unless they are a statement. Added t…

runtime/vm/ast.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_AST_H_
 #define VM_AST_H_
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
@@ skipping 1146 matching lines @@
   Token::Kind kind_;
   SourceLabel* label_;
   GrowableArray<InlinedFinallyNode*> inlined_finally_list_;
   DISALLOW_IMPLICIT_CONSTRUCTORS(JumpNode);
 };
 
 
 class LoadLocalNode : public AstNode {
  public:
   LoadLocalNode(intptr_t token_index, const LocalVariable& local)
-      : AstNode(token_index), local_(local) { }
+      : AstNode(token_index), local_(local), pseudo_(NULL) { }
+  // The pseudo node does not produce input but must be visited before
+  // completing local load.
+  LoadLocalNode(intptr_t token_index,
+                const LocalVariable& local,
+                AstNode* pseudo)
+      : AstNode(token_index), local_(local), pseudo_(pseudo) {}
 
   const LocalVariable& local() const { return local_; }
+  AstNode* pseudo() const { return pseudo_; }  // Can be NULL.
+  bool HasPseudo() const { return pseudo_ != NULL; }
 
-  virtual void VisitChildren(AstNodeVisitor* visitor) const { }
+  virtual void VisitChildren(AstNodeVisitor* visitor) const {
+    if (HasPseudo()) {
+      pseudo()->Visit(visitor);
+    }
+  }
 
   virtual AstNode* MakeAssignmentNode(AstNode* rhs);
 
   virtual AstNode* MakeIncrOpNode(intptr_t token_index,
                                   Token::Kind kind,
                                   bool is_prefix);
 
   DECLARE_COMMON_NODE_FUNCTIONS(LoadLocalNode);
 
  private:
   const LocalVariable& local_;
+  AstNode* pseudo_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(LoadLocalNode);
 };
 
 
 class StoreLocalNode : public AstNode {
  public:
   StoreLocalNode(intptr_t token_index,
                  const LocalVariable& local,
                  AstNode* value)
@@ skipping 681 matching lines @@
   const LocalVariable& context_var_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(InlinedFinallyNode);
 };
 
 }  // namespace dart
 
 #undef DECLARE_COMMON_NODE_FUNCTIONS
 
 #endif  // VM_AST_H_