Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: runtime/vm/code_generator_x64.cc

Issue 10283003: - Fix another side effect issue: never add AstNode to sequence unless they are a statement. Added t… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/code_generator.h" 8 #include "vm/code_generator.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
887 __ popq(Address(RCX, i * kWordSize)); 887 __ popq(Address(RCX, i * kWordSize));
888 } 888 }
889 889
890 if (IsResultNeeded(node)) { 890 if (IsResultNeeded(node)) {
891 __ pushq(RAX); 891 __ pushq(RAX);
892 } 892 }
893 } 893 }
894 894
895 895
896 void CodeGenerator::VisitLoadLocalNode(LoadLocalNode* node) { 896 void CodeGenerator::VisitLoadLocalNode(LoadLocalNode* node) {
897 if (node->HasPseudo()) {
898 node->pseudo()->Visit(this);
899 __ popq(RAX); // Discard result.
900 }
897 // Load the value of the local variable and push it onto the expression stack. 901 // Load the value of the local variable and push it onto the expression stack.
898 if (IsResultNeeded(node)) { 902 if (IsResultNeeded(node)) {
899 GeneratePushVariable(node->local(), RAX); 903 GeneratePushVariable(node->local(), RAX);
900 } 904 }
901 } 905 }
902 906
903 907
904 void CodeGenerator::VisitStoreLocalNode(StoreLocalNode* node) { 908 void CodeGenerator::VisitStoreLocalNode(StoreLocalNode* node) {
905 node->value()->Visit(this); 909 node->value()->Visit(this);
906 __ popq(RAX); 910 __ popq(RAX);
(...skipping 1824 matching lines...) Expand 10 before | Expand all | Expand 10 after
2731 const Error& error = Error::Handle( 2735 const Error& error = Error::Handle(
2732 Parser::FormatError(script, token_index, "Error", format, args)); 2736 Parser::FormatError(script, token_index, "Error", format, args));
2733 va_end(args); 2737 va_end(args);
2734 Isolate::Current()->long_jump_base()->Jump(1, error); 2738 Isolate::Current()->long_jump_base()->Jump(1, error);
2735 UNREACHABLE(); 2739 UNREACHABLE();
2736 } 2740 }
2737 2741
2738 } // namespace dart 2742 } // namespace dart
2739 2743
2740 #endif // defined TARGET_ARCH_X64 2744 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698