Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 10206017: Do not use overloaded toDartValue for bindings classes. (Closed)

Created:
8 years, 8 months ago by podivilov
Modified:
8 years, 8 months ago
Reviewers:
Anton Muhin, antonm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not use overloaded toDartValue for bindings classes. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -16 lines) Patch
M lib/dom/idl/dart/dart.idl View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/dom/scripts/generator.py View 5 chunks +8 lines, -5 lines 0 comments Download
M lib/dom/scripts/systemnative.py View 1 chunk +5 lines, -5 lines 0 comments Download
M lib/dom/templates/dom/native/cpp_header.template View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
podivilov
8 years, 8 months ago (2012-04-24 14:12:11 UTC) #1
Anton Muhin
8 years, 8 months ago (2012-04-24 14:19:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698