lib/dom/scripts/systemnative.py - Issue 10206017: Do not use overloaded toDartValue for bindings classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10206017: Do not use overloaded toDartValue for bindings classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/dom/scripts/systemnative.py

diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py

index 48d78d44580468130067f7ce1f5046d6747d768f..213f6b604f13c2488d4734a31a8a76d16d8542cc 100644

--- a/lib/dom/scripts/systemnative.py

+++ b/lib/dom/scripts/systemnative.py

@@ -396,13 +396,13 @@ class NativeImplementationGenerator(systemwrapping.WrappingInterfaceGenerator):

'CPPPureInterface' in self._interface.ext_attrs or

self._interface_type_info.custom_to_dart()):

to_dart_template = (

- 'Dart_Handle toDartValue($(WEBCORE_CLASS_NAME)* value);\n')

+ ' static Dart_Handle toDart($(WEBCORE_CLASS_NAME)* value);\n')

else:

to_dart_template = (

- 'inline Dart_Handle toDartValue($(WEBCORE_CLASS_NAME)* value)\n'

- '{\n'

- ' return DartDOMWrapper::toDart<Dart$(INTERFACE)>(value);\n'

- '}\n')

+ ' static Dart_Handle toDart($(WEBCORE_CLASS_NAME)* value)\n'

+ ' {\n'

+ ' return DartDOMWrapper::toDart<Dart$(INTERFACE)>(value);\n'

+ ' }\n')

intermediate_emitter = emitter.Emitter()

intermediate_emitter.Emit(

« no previous file with comments | « lib/dom/scripts/generator.py ('k') | lib/dom/templates/dom/native/cpp_header.template » ('j') | no next file with comments »