Do not use overloaded toDartValue for bindings classes.

lib/dom/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import re
 import string
@@ skipping 458 matching lines @@
         'Int8Array',
         'Int16Array',
         'Int32Array',
         'Uint8Array',
         'Uint16Array',
         'Uint32Array',
         'Uint8ClampedArray',
     ]
 
     if self._idl_type in WTF_INCLUDES:
-      return ['<wtf/%s.h>' % self._idl_type]
+      return ['<wtf/%s.h>' % self.native_type()]
 
     if not self._idl_type.startswith('SVG'):
-      return ['"%s.h"' % self._idl_type]
+      return ['"%s.h"' % self.native_type()]
 
     if self._idl_type in ['SVGNumber', 'SVGPoint']:
       return []
     if self._idl_type.startswith('SVGPathSeg'):
       include = self._idl_type.replace('Abs', '').replace('Rel', '')
     else:
       include = self._idl_type
     return ['"%s.h"' % include] + _svg_supplemental_includes
 
   def receiver(self):
     return 'receiver->'
 
   def conversion_includes(self):
     return ['"Dart%s.h"' % include for include in self._conversion_includes]
 
   def to_dart_conversion(self, value, interface_name=None, attributes=None):
-    return 'toDartValue(%s)' % value
+    return 'Dart%s::toDart(%s)' % (self._idl_type, value)
 
   def custom_to_dart(self):
     return self._custom_to_dart
 
 
 class SequenceIDLTypeInfo(IDLTypeInfo):
   def __init__(self, idl_type, item_info):
     super(SequenceIDLTypeInfo, self).__init__(idl_type)
     self._item_info = item_info
 
   def dart_type(self):
     return 'List<%s>' % self._item_info.dart_type()
 
+  def to_dart_conversion(self, value, interface_name=None, attributes=None):
+    return 'DartDOMWrapper::vectorToDart<Dart%s>(%s)' % (self._item_info.native_type(), value)
+
   def conversion_includes(self):
     return self._item_info.conversion_includes()
 
 
 class PrimitiveIDLTypeInfo(IDLTypeInfo):
   def __init__(self, idl_type, dart_type, native_type=None, ref_counted=False,
                webcore_getter_name='getAttribute',
                webcore_setter_name='setAttribute'):
     super(PrimitiveIDLTypeInfo, self).__init__(idl_type, dart_type=dart_type,
         native_type=native_type, ref_counted=ref_counted)
@@ skipping 60 matching lines @@
       conversion_cast = 'static_cast<%s*>(%s)'
     elif self.idl_type() == 'SVGStringList':
       conversion_cast = '%s::create(receiver, %s)'
     elif interface_name.endswith('List'):
       conversion_cast = 'static_cast<%s*>(%s.get())'
     elif self.idl_type() in svg_primitive_types:
       conversion_cast = '%s::create(%s)'
     else:
       conversion_cast = 'static_cast<%s*>(%s)'
     conversion_cast = conversion_cast % (self.native_type(), value)
-    return 'toDartValue(%s)' %  conversion_cast
+    return 'Dart%s::toDart(%s)' %  (self._idl_type, conversion_cast)
 
 _idl_type_registry = {
     'boolean': PrimitiveIDLTypeInfo('boolean', dart_type='bool', native_type='bool',
                                     webcore_getter_name='hasAttribute',
                                     webcore_setter_name='setBooleanAttribute'),
     'short': PrimitiveIDLTypeInfo('short', dart_type='int', native_type='int'),
     'unsigned short': PrimitiveIDLTypeInfo('unsigned short', dart_type='int',
         native_type='int'),
     'int': PrimitiveIDLTypeInfo('int', dart_type='int'),
     'unsigned int': PrimitiveIDLTypeInfo('unsigned int', dart_type='int',
@@ skipping 28 matching lines @@
     'SerializedScriptValue': PrimitiveIDLTypeInfo('SerializedScriptValue', dart_type='Dynamic', ref_counted=True),
     # TODO(sra): Flags is really a dictionary: {create:bool, exclusive:bool}
     # http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
     'WebKitFlags': PrimitiveIDLTypeInfo('WebKitFlags', dart_type='Object'),
 
     'DOMStringList': PrimitiveIDLTypeInfo('DOMStringList', dart_type='List<String>'),
     'sequence': PrimitiveIDLTypeInfo('sequence', dart_type='List'),
     'void': PrimitiveIDLTypeInfo('void', dart_type='void'),
 
     'CSSRule': IDLTypeInfo('CSSRule', conversion_includes=['CSSImportRule']),
-    'DOMException': IDLTypeInfo('DOMCoreException', dart_type='DOMException'),
+    'DOMException': IDLTypeInfo('DOMException', native_type='DOMCoreException'),
     'DOMStringMap': IDLTypeInfo('DOMStringMap', dart_type='Map<String, String>'),
     'DOMWindow': IDLTypeInfo('DOMWindow', custom_to_dart=True),
     'Element': IDLTypeInfo('Element', custom_to_dart=True),
     'EventListener': IDLTypeInfo('EventListener', custom_to_native=True),
     'EventTarget': IDLTypeInfo('EventTarget', custom_to_native=True),
     'HTMLElement': IDLTypeInfo('HTMLElement', custom_to_dart=True),
     'IDBAny': IDLTypeInfo('IDBAny', dart_type='Dynamic', custom_to_native=True),
     'IDBKey': IDLTypeInfo('IDBKey', dart_type='Dynamic', custom_to_native=True),
     'MediaQueryListListener': IDLTypeInfo('MediaQueryListListener', custom_to_native=True),
     'OptionsObject': IDLTypeInfo('OptionsObject', custom_to_native=True),
@@ skipping 23 matching lines @@
     '"SVGAnimatedListPropertyTearOff.h"',
     '"SVGTransformListPropertyTearOff.h"',
     '"SVGPathSegListPropertyTearOff.h"',
 ]
 
 def GetIDLTypeInfo(idl_type_name):
   match = re.match(r'sequence<(\w+)>$', idl_type_name)
   if match:
     return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
   return _idl_type_registry.get(idl_type_name, IDLTypeInfo(idl_type_name))