Reapply "Reduce size by emitting $.foo instead of Isolate.prototype.foo."

Reapply "Reduce size by emitting $.foo instead of Isolate.prototype.foo."

This reapplies (a fixed version of) 6459 which had been reverted with 6460.

Committed: https://code.google.com/p/dart/source/detail?r=6461

[floitsch, 2012-04-12 13:26:05]

Only needed to adjust the tests. Submitting TBR.

Original CL has already been TBRed:
https://chromiumcodereview.appspot.com//10052020

[Lasse Reichstein Nielsen, 2012-04-13 08:38:32]

LGTM

https://chromiumcodereview.appspot.com/10065015/diff/1/frog/tests/leg/src/Cla...
File frog/tests/leg/src/ClassCodegenTest.dart (right):

https://chromiumcodereview.appspot.com/10065015/diff/1/frog/tests/leg/src/Cla...
frog/tests/leg/src/ClassCodegenTest.dart:67:
Expect.isTrue(generated.contains("\$.A = function A() {\n};"));
You can use a raw string to avoid the escaped $ (like below).
Seems fragile to test the exact whitespace between { and }. We might avoid
inserting the newline. Try to use "\s*" instead.

[floitsch, 2012-04-13 08:59:59]

https://chromiumcodereview.appspot.com/10065015/diff/1/frog/tests/leg/src/Cla...
File frog/tests/leg/src/ClassCodegenTest.dart (right):

https://chromiumcodereview.appspot.com/10065015/diff/1/frog/tests/leg/src/Cla...
frog/tests/leg/src/ClassCodegenTest.dart:67:
Expect.isTrue(generated.contains("\$.A = function A() {\n};"));
On 2012/04/13 08:38:32, Lasse Reichstein Nielsen wrote:
> You can use a raw string to avoid the escaped $ (like below).
> Seems fragile to test the exact whitespace between { and }. We might avoid
> inserting the newline. Try to use "\s*" instead.

I would prefer keeping a string and not a regexp here. Therefore I cannot use a
raw-string (for the reason you mentioned).
Note that the regexp would need to escape the '$' again (since it would
otherwise be seen as line-end).