Issue 10052020: Reduce size by emitting $.foo instead of Isolate.prototype.foo.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -40 lines)			Patch
M	lib/compiler/implementation/emitter.dart	View	1 2 3 4	16 chunks	+41 lines, -32 lines	0 comments	Download
M	lib/compiler/implementation/namer.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/native_emitter.dart	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM https://chromiumcodereview.appspot.com/10052020/diff/1004/lib/compiler/implementation/emitter.dart File lib/compiler/implementation/emitter.dart (right): https://chromiumcodereview.appspot.com/10052020/diff/1004/lib/compiler/implementation/emitter.dart#newcode439 lib/compiler/implementation/emitter.dart:439: buffer.add(isolatePrototype); We should add an "<<" operator to ...

8 years, 8 months ago (2012-04-12 09:45:32 UTC) #2

floitsch

8 years, 8 months ago (2012-04-12 11:26:56 UTC) #3

Thanks. that made it much nicer.

https://chromiumcodereview.appspot.com/10052020/diff/1004/lib/compiler/implem...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10052020/diff/1004/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:439: buffer.add(isolatePrototype);
On 2012/04/12 09:45:32, Lasse Reichstein Nielsen wrote:
> We should add an "<<" operator to StringBuffer :)

hehe.

https://chromiumcodereview.appspot.com/10052020/diff/1004/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:588: void
emitNoSuchMethodCalls(StringBuffer buffer, String isolatePrototype) {
On 2012/04/12 09:45:32, Lasse Reichstein Nielsen wrote:
> Instead of passing isolatePrototype everywhere, could you make it a mutable
> field on the emitter object? It seems it only needs to change its name once,
and
> not have different values interchangably.

Done.

Expand Messages | Collapse Messages

Issue 10052020: Reduce size by emitting $.foo instead of Isolate.prototype.foo. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove another Isolate.prototype. #

Patch Set 3 : Address comments. #

Patch Set 4 : Remove unnecessary semicolon. #

Patch Set 5 : rebase #

Messages