Reapply "Reduce size by emitting $.foo instead of Isolate.prototype.foo."

frog/tests/leg/src/ClassCodegenTest.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Test that parameters keep their names in the output.
 
 #import("compiler_helper.dart");
 #import("parser_helper.dart");
 
 final String TEST_ONE = @"""
 class A { }
@@ skipping 46 matching lines @@
   A(x) : this.x = x {}
 }
 
 main() {
   new A(3);
 }
 """;
 
 twoClasses() {
   String generated = compileAll(TEST_ONE);
-  Expect.isTrue(generated.contains(
-      "Isolate.prototype.A = function A() {\n};"));
-  Expect.isTrue(generated.contains(
-      "Isolate.prototype.B = function B() {\n};"));
+  Expect.isTrue(generated.contains("\$.A = function A() {\n};"));

[Lasse Reichstein Nielsen, 2012/04/13 08:38:32]

You can use a raw string to avoid the escaped $ (like below).
Seems fragile to test the exact whitespace between { and }. We might avoid
inserting the newline. Try to use "\s*" instead.

[floitsch, 2012/04/13 08:59:59]

I would prefer keeping a string and not a regexp here. Therefore I cannot use a
raw-string (for the reason you mentioned).
Note that the regexp would need to escape the '$' again (since it would
otherwise be seen as line-end).

+  Expect.isTrue(generated.contains("\$.B = function B() {\n};"));
 }
 
 subClass() {
   checkOutput(String generated) {
-    Expect.isTrue(
-        generated.contains("Isolate.prototype.A = function A() {\n};"));
-    Expect.isTrue(
-        generated.contains("Isolate.prototype.B = function B() {\n};"));
+    Expect.isTrue(generated.contains("\$.A = function A() {\n};"));
+    Expect.isTrue(generated.contains("\$.B = function B() {\n};"));
     Expect.isTrue(generated.contains(@"Isolate.$inherits = function"));
-    Expect.isTrue(generated.contains(
-        "Isolate.\$inherits(Isolate.prototype.B, Isolate.prototype.A);\n"));
+    Expect.isTrue(generated.contains(@"Isolate.$inherits($.B, $.A);"));
   }
 
   checkOutput(compileAll(TEST_TWO));
   checkOutput(compileAll(TEST_THREE));
 }
 
 fieldTest() {
   String generated = compileAll(TEST_FOUR);
-  Expect.isTrue(generated.contains("""
-Isolate.prototype.B = function B(B_z, B_y, A_x) {
+  Expect.isTrue(generated.contains(@"""
+$.B = function B(B_z, B_y, A_x) {
   this.z = B_z;
   this.y = B_y;
   this.x = A_x;
 };"""));
 }
 
 constructor1() {
   String generated = compileAll(TEST_FIVE);
-  Expect.isTrue(generated.contains("new \$.A(x);"));
+  Expect.isTrue(generated.contains(@"new $.A(x);"));
 }
 
 main() {
   twoClasses();
   subClass();
   fieldTest();
   constructor1();
 }