Log when the host is started for an account.

remoting/host/host_event_logger_posix.cc

Index: remoting/host/host_event_logger_posix.cc
diff --git a/remoting/host/host_event_logger_posix.cc b/remoting/host/host_event_logger_posix.cc
index b29f9d26283fe2643eba2337028bf6b04a7ea37b..8c988e8358390ee838261165797d51a485c6354f 100644
--- a/remoting/host/host_event_logger_posix.cc
+++ b/remoting/host/host_event_logger_posix.cc
@@ -39,6 +39,9 @@ class HostEventLoggerPosix : public HostEventLogger, public HostStatusObserver {
       const protocol::TransportRoute& route) OVERRIDE;
   virtual void OnShutdown() OVERRIDE;
 
+  //HostEventLogger implementation.

[alexeypa (please no reviews), 2012/08/29 15:15:48]

nit: space in front of HostEventLogger

[rmsousa, 2012/08/29 19:24:40]

Done.

+  virtual void OnStart(const std::string& xmpp_login) OVERRIDE;
+
  private:
   void Log(const std::string& message);
 
@@ -56,7 +59,6 @@ HostEventLoggerPosix::HostEventLoggerPosix(ChromotingHost* host,
       application_name_(application_name) {
   openlog(application_name_.c_str(), 0, LOG_USER);
   host_->AddStatusObserver(this);
-  Log("Started");
 }
 
 HostEventLoggerPosix::~HostEventLoggerPosix() {
@@ -91,6 +93,10 @@ void HostEventLoggerPosix::OnClientRouteChange(
 void HostEventLoggerPosix::OnShutdown() {

[Jamie, 2012/08/29 17:24:14]

Much as I dislike "while you're here" type comments, it's very strange to me
that we don't log anything on shutdown. Can you add a shutdown message as well?

[rmsousa, 2012/08/29 19:24:40]

I added the message, but I think Lambros's comments on
https://chromiumcodereview.appspot.com/10800023#msg4 still apply - at least on
Linux I don't see it being executed. I can try looking at cleaning up our
shutdown next, if nobody else is already looking at it.
(also, at this point the xmpp_login used at start isn't stored anywhere (aside
from privately at signaling_strategy), so we don't have an easy way to log it
here).

[Jamie, 2012/08/30 06:09:33]

Ah yes, I remember now. Thanks for adding it, but I think that you were right
the first time and there's not much point having a log message that we know
never gets logged, particularly given the extra method and string resource that
needs to be added on Windows. Sorry about that; could you replace it with a TODO
along the lines of your suggested clean up above.

[rmsousa, 2012/08/30 16:29:03]

Done.

 }
 
+void HostEventLoggerPosix::OnStart(const std::string& xmpp_login) {
+  Log("Host started for user: " + xmpp_login);
+}
+
 void HostEventLoggerPosix::Log(const std::string& message) {
   syslog(LOG_USER | LOG_NOTICE, "%s", message.c_str());
 }