Log when the host is started for an account.

remoting/host/host_event_logger_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/host_event_logger.h"
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stringprintf.h"
 #include "net/base/ip_endpoint.h"
@@ skipping 21 matching lines @@
   // network thread.
   virtual void OnClientAuthenticated(const std::string& jid) OVERRIDE;
   virtual void OnClientDisconnected(const std::string& jid) OVERRIDE;
   virtual void OnAccessDenied(const std::string& jid) OVERRIDE;
   virtual void OnClientRouteChange(
       const std::string& jid,
       const std::string& channel_name,
       const protocol::TransportRoute& route) OVERRIDE;
   virtual void OnShutdown() OVERRIDE;
 
+  //HostEventLogger implementation.

[alexeypa (please no reviews), 2012/08/29 15:15:48]

nit: space in front of HostEventLogger

[rmsousa, 2012/08/29 19:24:40]

Done.

+  virtual void OnStart(const std::string& xmpp_login) OVERRIDE;
+
  private:
   void Log(const std::string& message);
 
   scoped_refptr<ChromotingHost> host_;
   std::string application_name_;
 
   DISALLOW_COPY_AND_ASSIGN(HostEventLoggerPosix);
 };
 
 } //namespace
 
 HostEventLoggerPosix::HostEventLoggerPosix(ChromotingHost* host,
                                            const std::string& application_name)
     : host_(host),
       application_name_(application_name) {
   openlog(application_name_.c_str(), 0, LOG_USER);
   host_->AddStatusObserver(this);
-  Log("Started");
 }
 
 HostEventLoggerPosix::~HostEventLoggerPosix() {
   host_->RemoveStatusObserver(this);
   closelog();
 }
 
 void HostEventLoggerPosix::OnClientAuthenticated(const std::string& jid) {
   Log("Client connected: " + jid);
 }
@@ skipping 11 matching lines @@
     const std::string& channel_name,
     const protocol::TransportRoute& route) {
   Log(base::StringPrintf(
       "Channel IP for client: %s ip='%s' host_ip='%s' channel='%s' "
       "connection='%s'",
       jid.c_str(), route.remote_address.ToString().c_str(),
       route.local_address.ToString().c_str(), channel_name.c_str(),
       protocol::TransportRoute::GetTypeString(route.type).c_str()));
 }
 
 void HostEventLoggerPosix::OnShutdown() {

[Jamie, 2012/08/29 17:24:14]

Much as I dislike "while you're here" type comments, it's very strange to me
that we don't log anything on shutdown. Can you add a shutdown message as well?

[rmsousa, 2012/08/29 19:24:40]

I added the message, but I think Lambros's comments on
https://chromiumcodereview.appspot.com/10800023#msg4 still apply - at least on
Linux I don't see it being executed. I can try looking at cleaning up our
shutdown next, if nobody else is already looking at it.
(also, at this point the xmpp_login used at start isn't stored anywhere (aside
from privately at signaling_strategy), so we don't have an easy way to log it
here).

[Jamie, 2012/08/30 06:09:33]

Ah yes, I remember now. Thanks for adding it, but I think that you were right
the first time and there's not much point having a log message that we know
never gets logged, particularly given the extra method and string resource that
needs to be added on Windows. Sorry about that; could you replace it with a TODO
along the lines of your suggested clean up above.

[rmsousa, 2012/08/30 16:29:03]

Done.

 }
 
+void HostEventLoggerPosix::OnStart(const std::string& xmpp_login) {
+  Log("Host started for user: " + xmpp_login);
+}
+
 void HostEventLoggerPosix::Log(const std::string& message) {
   syslog(LOG_USER | LOG_NOTICE, "%s", message.c_str());
 }
 
 // static
 scoped_ptr<HostEventLogger> HostEventLogger::Create(
     ChromotingHost* host, const std::string& application_name) {
   return scoped_ptr<HostEventLogger>(
       new HostEventLoggerPosix(host, application_name));
 }
 
 }  // namespace remoting