Log host startup (Linux/Mac)

Log host startup (Linux/Mac)


BUG=132683
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147383

[Lambros, 2012-07-18 23:05:20]

I also tried adding a "shutdown" log (though we don't need it), but neither the
Shutdown() method, nor the HostEventLogger dtor actually gets called.

[Jamie, 2012-07-18 23:21:33]

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
File remoting/host/host_event_logger_posix.cc (right):

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
remoting/host/host_event_logger_posix.cc:59: Log("Host started");
Please run this string by the relevant stakeholders to make sure it's specific
enough. Ideally, it should be possible to identify all of our log messages with
a single grep.

[Sergey Ulanov, 2012-07-18 23:28:16]

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
File remoting/host/host_event_logger_posix.cc (right):

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
remoting/host/host_event_logger_posix.cc:59: Log("Host started");
On 2012/07/18 23:21:34, Jamie wrote:
> Please run this string by the relevant stakeholders to make sure it's specific
> enough. Ideally, it should be possible to identify all of our log messages
with
> a single grep.

It's already possible to do that - syslog logs application name next to each
message. application name is specified in the openlog() call above.

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
remoting/host/host_event_logger_posix.cc:64: closelog();
also log when the host is stopped?

[Lambros, 2012-07-18 23:40:56]

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
File remoting/host/host_event_logger_posix.cc (right):

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
remoting/host/host_event_logger_posix.cc:59: Log("Host started");
On 2012/07/18 23:21:34, Jamie wrote:
> Please run this string by the relevant stakeholders to make sure it's specific
> enough. Ideally, it should be possible to identify all of our log messages
with
> a single grep.
I think this string is sufficiently distinctive from the other strings logged
here.  If an objection is raised, we can always change it again :)

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
remoting/host/host_event_logger_posix.cc:64: closelog();
On 2012/07/18 23:28:17, sergeyu wrote:
> also log when the host is stopped?
For Linux Me2Me at least, that code doesn't seem to get called when the host
process is terminated.  Some work would be needed in order to handle SIGTERM
(and maybe other signals) to cause a teardown of these objects.  Since logging
of shutdown wasn't requested, it is probably not worth the effort to do this
work.

[Wez, 2012-07-19 00:41:29]

lgtm

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
File remoting/host/host_event_logger_posix.cc (right):

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
remoting/host/host_event_logger_posix.cc:59: Log("Host started");
nit: I think this can simply be "Started" - we already know it's the host
logging it in both syslog and Windows' Event Log.

[Lambros, 2012-07-19 01:36:34]

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
File remoting/host/host_event_logger_posix.cc (right):

http://codereview.chromium.org/10800023/diff/1/remoting/host/host_event_logge...
remoting/host/host_event_logger_posix.cc:59: Log("Host started");
On 2012/07/19 00:41:29, Wez wrote:
> nit: I think this can simply be "Started" - we already know it's the host
> logging it in both syslog and Windows' Event Log.
OK.  If we ever need Host/Client distinction, that should go in the
application_name.

[commit-bot: I haz the power, 2012-07-19 01:37:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10800023/7001

[commit-bot: I haz the power, 2012-07-19 02:54:34]

Change committed as 147383