Issue 10263021: Fix sanitize-rule-names test for scons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10263021: Fix sanitize-rule-names test for scons. (Closed)

Created:
8 years, 7 months ago by scottmg

Modified:
8 years, 7 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix sanitize-rule-names test for scons. The scons generator didn't remove invalid characters from rule names; remap those. It also doesn't seem to support building files of extensions other than a built-in list. So, use .S rather than .X for this test since it doesn't matter to the test. R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1348

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	pylib/gyp/generator/scons.py	View	3 chunks	+3 lines, -2 lines	0 comments	Download
A	test/sanitize-rule-names/blah.S	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	test/sanitize-rule-names/sanitize-rule-names.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages