Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: pylib/gyp/generator/scons.py

Issue 10263021: Fix sanitize-rule-names test for scons. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/sanitize-rule-names/blah.S » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/scons.py
===================================================================
--- pylib/gyp/generator/scons.py (revision 1347)
+++ pylib/gyp/generator/scons.py (working copy)
@@ -1,4 +1,4 @@
-# Copyright (c) 2011 Google Inc. All rights reserved.
+# Copyright (c) 2012 Google Inc. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -8,6 +8,7 @@
import os.path
import pprint
import re
+import string
# TODO: remove when we delete the last WriteList() call in this module
@@ -462,7 +463,7 @@
rules = spec.get('rules', [])
for rule in rules:
- name = rule['rule_name']
+ name = rule['rule_name'].translate(string.maketrans(' ()-', '____'))
a = ['cd', src_subdir, '&&'] + rule['action']
message = rule.get('message')
if message:
« no previous file with comments | « no previous file | test/sanitize-rule-names/blah.S » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698