Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 99923008: Merged r17459, r17462, r17474 into 3.20 branch. (Closed)

Created:
7 years ago by ulan
Modified:
7 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r17459, r17462, r17474 into 3.20 branch. Add missing negative dictionary lookup to NonexistentHandlerFrontend Restore intended LoadIC behavior for JSBuiltinsObject Proper fix for the issue exposed by r17459 BUG=v8:2980 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -260 lines) Patch
M src/arm/stub-cache-arm.cc View 6 chunks +23 lines, -49 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 7 chunks +28 lines, -54 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 6 chunks +23 lines, -52 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/stub-cache.h View 4 chunks +32 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 2 chunks +37 lines, -3 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 7 chunks +28 lines, -57 lines 0 comments Download
A + test/mjsunit/regress/regress-2980.js View 1 chunk +29 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
7 years ago (2013-12-17 09:44:25 UTC) #1
ulan
I applied diff from http://code.google.com/p/v8/source/detail?r=17650 to 3.20
7 years ago (2013-12-17 09:45:03 UTC) #2
Jakob Kummerow
LGTM.
7 years ago (2013-12-17 09:49:27 UTC) #3
ulan
7 years ago (2013-12-17 10:02:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18320.

Powered by Google App Engine
This is Rietveld 408576698