Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 9982015: Addressing comments from msw and rsleevi for the following patch which is (Closed)

Created:
8 years, 8 months ago by Munjal (Google)
Modified:
8 years, 8 months ago
Reviewers:
msw, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, jstritar, sail
Visibility:
Public.

Description

Addressing comments from msw and rsleevi for the following patch which is already committed: https://chromiumcodereview.appspot.com/9937004/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M chrome/common/net/gaia/oauth2_api_call_flow.h View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/common/net/gaia/oauth2_api_call_flow.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Munjal (Google)
8 years, 8 months ago (2012-04-04 19:25:21 UTC) #1
msw
LGTM; thanks for going back to fix nits!
8 years, 8 months ago (2012-04-05 01:44:55 UTC) #2
Ryan Sleevi
8 years, 8 months ago (2012-04-05 01:46:19 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698