Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2383)

Unified Diff: chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc

Issue 9982015: Addressing comments from msw and rsleevi for the following patch which is (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/gaia/oauth2_api_call_flow.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc
===================================================================
--- chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc (revision 130661)
+++ chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc (working copy)
@@ -32,6 +32,7 @@
using testing::Return;
namespace {
+
static GURL CreateApiUrl() {
return GURL("https://www.googleapis.com/someapi");
}
@@ -42,8 +43,9 @@
scopes.push_back("scope2");
return scopes;
}
-}
+} // namespace
+
class MockUrlFetcherFactory : public ScopedURLFetcherFactory,
public URLFetcherFactory {
public:
@@ -94,7 +96,6 @@
MOCK_METHOD1(ProcessMintAccessTokenFailure,
void (const GoogleServiceAuthError& error));
MOCK_METHOD0(CreateAccessTokenFetcher, OAuth2AccessTokenFetcher* ());
- // MOCK_METHOD0(CreateURLFetcher, URLFetcher* ());
};
class OAuth2ApiCallFlowTest : public testing::Test {
« no previous file with comments | « chrome/common/net/gaia/oauth2_api_call_flow.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698