Show an error if a field has no getter defined in a getter context

Show an error if a field has no getter defined in a getter context

http://code.google.com/p/dart/issues/detail?id=2408

Committed: https://code.google.com/p/dart/source/detail?r=6199

[zundel, 2012-04-04 14:47:42]

On 2012/04/04 14:26:55, zundel wrote:

Wait, I didn't make any JUnit test for this change...

[zundel, 2012-04-04 18:41:16]

Ready for review, added JUnit Test

[scheglov, 2012-04-04 20:57:09]

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/Elements.java (right):

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Elements.java:606: * @return
3 useless lines

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Elements.java:608: public static
boolean inGetterContext(DartPropertyAccess node) {
"on the left hand side", but method is named "inGetterContext"?
I don't understand this.

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Elements.java:622: public static
boolean inSetterContext(DartNode node) {
Hm...
May be you just exchanged comments for these two methods?

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1063: 
What is difference between this code and same code in TypeAnalyzer?
Do we need both?

[zundel, 2012-04-04 21:34:48]

PTAL

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/Elements.java (right):

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Elements.java:606: * @return
On 2012/04/04 20:57:09, scheglov wrote:
> 3 useless lines

Done.

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Elements.java:608: public static
boolean inGetterContext(DartPropertyAccess node) {
On 2012/04/04 20:57:09, scheglov wrote:
> "on the left hand side", but method is named "inGetterContext"?
> I don't understand this.
Sorry about that.  I tried to clean this up.

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Elements.java:622: public static
boolean inSetterContext(DartNode node) {
On 2012/04/04 20:57:09, scheglov wrote:
> Hm...
> May be you just exchanged comments for these two methods?

Done.

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/9979004/diff/5001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1063: 
On 2012/04/04 20:57:09, scheglov wrote:
> What is difference between this code and same code in TypeAnalyzer?
> Do we need both?

This is specific to static methods, and they are compile time errors.  The logic
in TypeAnalyzer is a warning only.

[scheglov, 2012-04-04 21:38:24]

LGTM